Gabriel Radureau
189d44d70f
Follow-up to PR #48 after user question on whether mutex/atomic would be a cleaner fix than removing the log call. Honest answer: the racing memory location is zerolog's global gLevel, which IS already mutated atomically by zerolog itself. The race detector flags it because LoadConfig → SetupLogging writes gLevel via zerolog.SetGlobalLevel and a leaked watcher goroutine reads gLevel via log.Info() — both atomic individually, but go test -race treats the write/read pair as a happens-before violation across goroutine boundaries when there's no synchronization between them. A mutex on Config would not help: the shared state isn't on Config, it's on zerolog's package-level global. atomic.Pointer wouldn't help for the same reason. Combined fix: 1. Keep the log-removal (PR #48) — it's the actual race source: our cancel-handler goroutine's log.Info("watcher stopped") was the reading party. Add a longer comment explaining WHY it's gone. 2. Add pkg/config/main_test.go with TestMain that disables zerolog globally during the test suite. Defense in depth: any FUTURE leaked log call from a watcher-related goroutine won't trigger a race either, because no log call evaluates against the level. Production behavior unchanged. SetupLogging in production runs once at startup before any goroutine could race with it. go test -race -count=2 ./pkg/config/... passes (was failing).
dance-lessons-coach
Go web service demonstrating idiomatic package structure, versioned JSON API, and production-ready features.
Features
- Versioned JSON API (
/api/v1,/api/v2) - Chi router with graceful shutdown
- Zerolog structured logging (console and JSON modes)
- Viper configuration (file + env vars)
- Readiness endpoint for Kubernetes / service mesh
- OpenTelemetry / Jaeger distributed tracing
- OpenAPI / Swagger UI (embedded in binary)
- PostgreSQL user service with JWT auth
- BDD + unit tests
Quick Start
git clone https://gitea.arcodange.lab/arcodange/dance-lessons-coach.git
cd dance-lessons-coach
./scripts/build.sh # produces ./bin/server and ./bin/greet
./scripts/start-server.sh start
curl http://localhost:8080/api/health
curl http://localhost:8080/api/v1/greet/Alice
Stop: ./scripts/start-server.sh stop
Greet CLI
go run ./cmd/greet # Hello world!
go run ./cmd/greet Alice # Hello Alice!
Configuration
All options are available via config.yaml or DLC_* environment variables.
| Env var | Default | Description |
|---|---|---|
DLC_SERVER_PORT |
8080 |
Listening port |
DLC_SERVER_HOST |
0.0.0.0 |
Bind address |
DLC_LOGGING_JSON |
false |
JSON log format |
DLC_LOGGING_OUTPUT |
stderr | Log file path |
DLC_SHUTDOWN_TIMEOUT |
30s |
Graceful shutdown window |
DLC_API_V2_ENABLED |
false |
Enable /api/v2 routes |
DLC_CONFIG_FILE |
./config.yaml |
Override config path |
See config.example.yaml for a full template.
API
| Method | Path | Description |
|---|---|---|
| GET | /api/health |
Liveness check |
| GET | /api/ready |
Readiness check (503 during shutdown) |
| GET | /api/version |
Version info (?format=plain|full|json) |
| GET | /api/v1/greet/ |
Default greeting |
| GET | /api/v1/greet/{name} |
Named greeting |
| POST | /api/v2/greet |
V2 greeting with validation |
| GET | /swagger/ |
Swagger UI |
Testing
go test ./... # unit + integration tests
./scripts/test-graceful-shutdown.sh # lifecycle + JSON logging validation
./scripts/test-opentelemetry.sh # tracing end-to-end
Gitea Client
AI agent helper script at .vibe/skills/gitea-client/scripts/gitea-client.sh.
Auth setup:
echo "your_token" > ~/.gitea_token
chmod 600 ~/.gitea_token
export GITEA_API_TOKEN_FILE="$HOME/.gitea_token"
Get a token at https://gitea.arcodange.lab → Profile → Settings → Applications.
Architecture
Key decisions are documented in adr/. See AGENTS.md for the full development reference (commands, config, ADR index, commit conventions).
License
MIT