arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

🐛 fix(ci): remove dollar-double-brace expression from comment that still gets interpolated #47

Merged
arcodange merged 2 commits from fix/ci-comment-still-interpolates into main 2026-05-05 09:34:01 +02:00
Conversation 0 Commits 2 Files Changed 4 +322 -10
arcodange commented 2026-05-05 09:33:53 +02:00
Owner
Copy Link

Follow-up to PR #38. The runner interpolates expression syntax even inside bash comments — my fix kept a reference in a comment that re-injected the multi-line commit body and broke parsing on the next line. Symptom (still firing on PRs #40-#45): line 32 syntax error: unexpected newline → Update badges step fails. Fix: rewrite the comment without the literal expression. The other 3 references in the YAML are in if: contains(...) job-level conditions evaluated server-side as booleans — safe.

Follow-up to PR #38. The runner interpolates expression syntax even inside bash comments — my fix kept a reference in a comment that re-injected the multi-line commit body and broke parsing on the next line. Symptom (still firing on PRs #40-#45): line 32 syntax error: unexpected newline → Update badges step fails. Fix: rewrite the comment without the literal expression. The other 3 references in the YAML are in if: contains(...) job-level conditions evaluated server-side as booleans — safe.
arcodange added 2 commits 2026-05-05 09:33:54 +02:00
feat(config): add sampler hot-reload callback for ADR-0023 Phase 3.2 2eb69f2709 
- Add SamplerReconfigureFunc type and SetSamplerReconfigureCallback method
- Track previous sampler type/ratio values to detect changes
- Invoke callback when telemetry.sampler.type or ratio changes
- Fix race condition in WatchAndApply cleanup using watcherStopped flag
- Add unit tests for sampler type/ratio hot-reload scenarios
- Update ADR-0023 status to reflect Phase 3.2 in flight

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
🐛 fix(ci): remove ${{ ... }} expression from comment that still gets interpolated b16f78294d 
Follow-up to PR #38. That PR fixed the SHELL line (replaced
${{ github.event.head_commit.message }} with git log) but kept a comment
mentioning the expression literally. Comments are not exempt: the
runner template engine interpolates ${{ ... }} BEFORE bash sees the
script, so the multi-line commit body still ended up injected mid-comment
and broke bash parsing on the next line.

Symptom (still fired on PRs #40-#45 even after PR #38):
  /var/run/act/workflow/12.sh: line 32: syntax error: unexpected newline
  ❌  Failure - Update badges and version

Fix: rewrite the comment without the literal expression. The other 3
references to head_commit.message in this file are inside job-level if:
contains(...) checks which are evaluated server-side as booleans, not
interpolated into shell — those are safe and unchanged.

Lesson for the verifier checklist: when fixing template-injection bugs,
search the WHOLE FILE for the expression including comments, not just
active code lines.
arcodange merged commit 3d9746ed65 into main 2026-05-05 09:34:01 +02:00
arcodange deleted branch fix/ci-comment-still-interpolates 2026-05-05 09:34:02 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
arcodange
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#47
Delete Branch "fix/ci-comment-still-interpolates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?