arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat(config): add sampler hot-reload callback for ADR-0023 Phase 3.2 #46

Closed
arcodange wants to merge 1 commits from feat/adr-0023-phase3b-sampler-reload into main
pull from: feat/adr-0023-phase3b-sampler-reload
merge into: arcodange:main
Conversation 0 Commits 1 Files Changed 3 +317 -6
arcodange commented 2026-05-05 09:32:22 +02:00
Owner
Copy Link

Closed without merge — content of this PR was accidentally bundled into PR #47 due to a working-directory race condition between two parallel sessions (Claude + Mistral autonomous, both operating on the same git checkout). When Claude opened a fix/ci-... branch while Mistral's feat/adr-0023-phase3b-sampler-reload was the active branch in the working directory, the new branch was created from Mistral's tip rather than main, causing PR #47's squash merge to bundle this PR's diff. Race condition flagged as Q-038 in ~/.vibe/memory/reference/mistral-quirks.md for future avoidance. Net effect: Mistral's autonomous Phase 3.2 work IS now on main (commit 3d9746e), just under a wrong PR title. A follow-up race fix landed in PR #48.

**Closed without merge** — content of this PR was accidentally bundled into [PR #47](https://gitea.arcodange.lab/arcodange/dance-lessons-coach/pulls/47) due to a working-directory race condition between two parallel sessions (Claude + Mistral autonomous, both operating on the same git checkout). When Claude opened a `fix/ci-...` branch while Mistral's `feat/adr-0023-phase3b-sampler-reload` was the active branch in the working directory, the new branch was created from Mistral's tip rather than `main`, causing PR #47's squash merge to bundle this PR's diff. Race condition flagged as Q-038 in `~/.vibe/memory/reference/mistral-quirks.md` for future avoidance. Net effect: Mistral's autonomous Phase 3.2 work IS now on main (commit `3d9746e`), just under a wrong PR title. A follow-up race fix landed in PR #48.
arcodange added 1 commit 2026-05-05 09:32:23 +02:00
feat(config): add sampler hot-reload callback for ADR-0023 Phase 3.2 2eb69f2709 
- Add SamplerReconfigureFunc type and SetSamplerReconfigureCallback method
- Track previous sampler type/ratio values to detect changes
- Invoke callback when telemetry.sampler.type or ratio changes
- Fix race condition in WatchAndApply cleanup using watcherStopped flag
- Add unit tests for sampler type/ratio hot-reload scenarios
- Update ADR-0023 status to reflect Phase 3.2 in flight

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
arcodange closed this pull request 2026-05-05 09:40:17 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
arcodange
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#46
Delete Branch "feat/adr-0023-phase3b-sampler-reload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?