Follow-up to PR #38. That PR fixed the SHELL line (replaced
${{ github.event.head_commit.message }} with git log) but kept a comment
mentioning the expression literally. Comments are not exempt: the
runner template engine interpolates ${{ ... }} BEFORE bash sees the
script, so the multi-line commit body still ended up injected mid-comment
and broke bash parsing on the next line.
Symptom (still fired on PRs #40-#45 even after PR #38):
/var/run/act/workflow/12.sh: line 32: syntax error: unexpected newline
❌ Failure - Update badges and version
Fix: rewrite the comment without the literal expression. The other 3
references to head_commit.message in this file are inside job-level if:
contains(...) checks which are evaluated server-side as booleans, not
interpolated into shell — those are safe and unchanged.
Lesson for the verifier checklist: when fixing template-injection bugs,
search the WHOLE FILE for the expression including comments, not just
active code lines.
- Add SamplerReconfigureFunc type and SetSamplerReconfigureCallback method
- Track previous sampler type/ratio values to detect changes
- Invoke callback when telemetry.sampler.type or ratio changes
- Fix race condition in WatchAndApply cleanup using watcherStopped flag
- Add unit tests for sampler type/ratio hot-reload scenarios
- Update ADR-0023 status to reflect Phase 3.2 in flight
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
