arcodange/mediabunny
1
0
Fork 0
mirror of https://github.com/arcodange-org/mediabunny.git synced 2026-09-27 10:53:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix async race condition bug

Browse Source
This commit is contained in:
Vanilagy
2025-05-08 16:23:07 +02:00
parent 94b797e227
commit 865fdcf110
3 changed files with 49 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/media-source.ts
+18 -6
View File
@@ -278,10 +278,16 @@ class VideoEncoderWrapper {
}
if (!this.encoderInitialized) {
if (this.ensureEncoderPromise) {
if (!this.ensureEncoderPromise) {
void this.ensureEncoder(videoSample);
}
// No, this "if" statement is not useless. Sometimes, the above call to `ensureEncoder` might have
// synchronously completed and the encoder is already initialized. In this case, we don't need to await the
// promise anymore. This also fixes nasty async race condition bugs when multiple code paths are calling
// this method: It's important that the call that initialized the encoder go through this code first.
if (!this.encoderInitialized) {
await this.ensureEncoderPromise;
} else {
await this.ensureEncoder(videoSample);
}
}
assert(this.encoderInitialized);
@@ -763,10 +769,16 @@ class AudioEncoderWrapper {
}
if (!this.encoderInitialized) {
if (this.ensureEncoderPromise) {
if (!this.ensureEncoderPromise) {
void this.ensureEncoder(audioSample);
}
// No, this "if" statement is not useless. Sometimes, the above call to `ensureEncoder` might have
// synchronously completed and the encoder is already initialized. In this case, we don't need to await the
// promise anymore. This also fixes nasty async race condition bugs when multiple code paths are calling
// this method: It's important that the call that initialized the encoder go through this code first.
if (!this.encoderInitialized) {
await this.ensureEncoderPromise;
} else {
await this.ensureEncoder(audioSample);
}
}
assert(this.encoderInitialized);