arcodange/mediabunny
1
0
Fork 0
mirror of https://github.com/arcodange-org/mediabunny.git synced 2026-09-27 10:53:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove InputTrack[] option for ConversionOptions.tracks

Browse Source
This commit is contained in:
Vanilagy
2026-04-15 10:30:26 +02:00
parent 42d0c22f5a
commit 606ee87822
1 changed files with 23 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/conversion.ts
+23 -35
View File
@@ -72,10 +72,8 @@ export type ConversionOptions = {
*
* - `'all'`: All input tracks are eligible for conversion.
* - `'primary'`: Only the primary video and audio track from the input are eligible for conversion.
* - Array: A user-specified list of tracks that are eligible for conversion. These must all belong to the
* {@link Input} specified in {@link ConversionOptions.input}.
*/
tracks?: 'all' | 'primary' | InputTrack[];
tracks?: 'all' | 'primary';
/**
* Video-specific options. When passing an object, the same options are applied to all video tracks. When passing a
@@ -619,19 +617,13 @@ export class Conversion {
}
if (
options.tracks !== undefined
&& !(
options.tracks === 'all'
|| options.tracks === 'primary'
|| (Array.isArray(options.tracks) && options.tracks.every(x => x instanceof InputTrack))
)
&& options.tracks !== 'all'
&& options.tracks !== 'primary'
) {
throw new TypeError(
'options.tracks, when provded, must be either \'all\', \'primary\', or an array of InputTrack.',
'options.tracks, when provded, must be either \'all\' or \'primary\'.',
);
}
if (Array.isArray(options.tracks) && !options.tracks.every(x => x.input === options.input)) {
throw new TypeError('Currently, all tracks in options.tracks must belong to options.input.');
}
if (
options.output._tracks.length > 0
|| Object.keys(options.output._metadataTags).length > 0
@@ -708,30 +700,26 @@ export class Conversion {
let tracks: InputTrack[];
if (Array.isArray(this._options.tracks)) {
tracks = this._options.tracks;
let trackMode = this._options.tracks;
if (trackMode === undefined) {
// HACK to keep bundle size low, temp for now
const defaultTrackMode = inputFormat.name.includes('(HLS)')
? 'primary'
: 'all';
trackMode = defaultTrackMode;
}
if (trackMode === 'all') {
tracks = await this.input.getTracks();
} else if (trackMode === 'primary') {
const primaryVideoTrack = await this.input.getPrimaryVideoTrack();
const primaryAudioTrack = await this.input.getPrimaryAudioTrack();
tracks = [primaryVideoTrack, primaryAudioTrack].filter(x => x !== null);
} else {
let trackMode = this._options.tracks;
if (trackMode === undefined) {
// HACK to keep bundle size low, temp for now
const defaultTrackMode = inputFormat.name.includes('(HLS)')
? 'primary'
: 'all';
trackMode = defaultTrackMode;
}
if (trackMode === 'all') {
tracks = await this.input.getTracks();
} else if (trackMode === 'primary') {
const primaryVideoTrack = await this.input.getPrimaryVideoTrack();
const primaryAudioTrack = await this.input.getPrimaryAudioTrack();
tracks = [primaryVideoTrack, primaryAudioTrack].filter(x => x !== null);
} else {
assertNever(trackMode);
assert(false);
}
assertNever(trackMode);
assert(false);
}
const outputTrackCounts = this.output.format.getSupportedTrackCounts();