## Summary Homogenize all 23 ADRs to a single canonical header format, and rewrite `adr/README.md` to match the actual state of the corpus. This is **Tâche 7** of the ARCODANGE Phase 1 migration (Claude Code → Mistral Vibe). Independent from PR #17 (Tâche 6 — restructure AGENTS.md) — both can merge in any order. No code changes; only documentation. ## Changes ### 1. Homogenize 21 ADR headers (commit `db09d0a`) The audit (Tâche 6 Phase A, Mistral intent-router agent, 2026-05-02) had identified **3 inconsistent header formats** : - **F1** — list bullets (`* Status:` / `* Date:` / `* Deciders:`) : 11 ADRs (0001-0008, 0011, 0014, 0023) - **F2** — bold fields (`**Status:**` / `**Date:**` / `**Authors:**`) : 9 ADRs (0009, 0010, 0012, 0013, 0015, 0016, 0017, 0018, 0019) - **F3** — dedicated section (`## Status\n**Value** ✅`) : 5 ADRs (0020, 0021, 0022, 0024, 0025) Plus mixed metadata names (Authors / Deciders / Decision Date / Implementation Date / Implementation Status / Last Updated) and decorative emojis on status values made the corpus hard to scan or template against. **Canonical format adopted** (see `adr/README.md` for full template) : ```markdown # NN. Title **Status:** <Proposed | Accepted | Implemented | Partially Implemented | Approved | Rejected | Deferred | Deprecated | Superseded by ADR-NNNN> **Date:** YYYY-MM-DD **Authors:** Name(s) [optional **Field:** ... lines] ## Context... ``` **Transformations applied** (via `/tmp/homogenize-adrs.py` script, 23 files scanned, 21 modified — 0010 and 0012 were already conform) : - F1 list bullets → bold fields - F2 cleanup : `**Deciders:**` → `**Authors:**`, strip status emojis - F3 sections : `## Status\n**Value** ✅` → `**Status:** Value` (single line) - Strip decorative emojis from `**Status:**` and `**Implementation Status:**` - Convert `* Last Updated:` / `* Implementation Status:` / `* Decision Drivers:` / `* Decision Date:` to bold - Date typo fix : `2024-04-XX` → `2026-04-XX` for ADRs 0018, 0019 (off-by-2-years in original) - Normalize multiple blank lines after header (max 1) **ADR body content is preserved unchanged.** Only headers transformed. ### 2. Rewrite `adr/README.md` (commit `d64ab02`) Previous README had multiple inconsistencies : - Index table listed wrong titles for ADRs 0010-0021 (looked like an aspirational forecast that never matched reality — e.g. "0011 = Trunk-Based Development" but real 0011 is absent and Trunk-Based Development is actually 0017) - Listed entries for ADRs 0011 (validation library) and 0014 (gRPC) but **these files do not exist** in the repo - 0024 (BDD Test Organization) was missing from the detail list - Template still showed the obsolete F1 format (`* Status:`) - Decorative emojis on every status entry Rewrite : - Index table **regenerated from actual file contents** (title from H1, status from `**Status:**` line) — emoji-free, accurate - Notes that 0011 / 0014 are not currently in use (reserved) - Updated template block matches the canonical format - Status Legend extended with `Approved`, `Partially Implemented`, `Deferred` - Added note that 0026 is the next free number for new ADRs ## Test plan - [x] All 23 ADRs follow `**Status:**` / `**Date:**` / `**Authors:**` (verified via grep) - [x] No more occurrences of `* Status:` (F1) or `## Status` (F3) in any ADR header - [x] No more emojis on `**Status:**` lines - [x] `adr/README.md` index links resolve to existing files (no more 0011 / 0014 dead links) - [x] Pre-commit hooks pass (`go mod tidy`, `go fmt`, `swag fmt`) ## Migration context Part of Phase 1 of the ARCODANGE migration from Claude Code to Mistral Vibe. Tâche 7 of the curriculum. Independent from PR #17 (which restructures `AGENTS.md`). The two PRs touch disjoint files — no merge conflict expected when both are merged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) (Opus 4.7, 1M context). Mistral Vibe (intent-router agent / mistral-medium-3.5) did the original audit identifying the 3 formats during Tâche 6 Phase A. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: Mistral Vibe (devstral-2 / mistral-medium-3.5) Reviewed-on: #18 Co-authored-by: Gabriel Radureau <arcodange@gmail.com> Co-committed-by: Gabriel Radureau <arcodange@gmail.com>
140 lines
5.4 KiB
Markdown
140 lines
5.4 KiB
Markdown
# Use Zerolog for structured logging
|
|
|
|
**Status:** Accepted
|
|
**Authors:** Gabriel Radureau, AI Agent
|
|
**Date:** 2026-04-02
|
|
|
|
## Context and Problem Statement
|
|
|
|
We needed to choose a logging library for dance-lessons-coach that provides:
|
|
- High performance with minimal overhead
|
|
- Structured logging capabilities
|
|
- Multiple output formats (console, JSON)
|
|
- Context-aware logging
|
|
- Good integration with our existing architecture
|
|
|
|
## Decision Drivers
|
|
|
|
* Need for high-performance logging in web service
|
|
* Desire for structured logs for better observability
|
|
* Requirement for context propagation through calls
|
|
* Need for flexible output formatting
|
|
* Easy integration with existing codebase
|
|
|
|
## Considered Options
|
|
|
|
* Zerolog - High-performance structured logging
|
|
* Logrus - Popular but slower
|
|
* Zap - Very fast but more complex
|
|
* Standard library log - Simple but limited
|
|
|
|
## Decision Outcome
|
|
|
|
Chosen option: "Zerolog" because it provides excellent performance, clean API, good structured logging support, and easy context integration while being simpler than Zap.
|
|
|
|
## Pros and Cons of the Options
|
|
|
|
### Zerolog
|
|
|
|
* Good, because extremely high performance (within ~15% of Zap in benchmarks)
|
|
* Good, because clean, simple API reduces cognitive load and maintenance overhead
|
|
* Good, because excellent structured logging support with minimal boilerplate
|
|
* Good, because good context integration with zero-allocation in no-op scenarios
|
|
* Good, because supports multiple output formats (console, JSON) with easy switching
|
|
* Good, because slightly better memory allocation profile than Zap (3-4 alloc vs 4-6 alloc in typical scenarios)
|
|
* Good, because adequate performance for our use case (<1μs difference per log call)
|
|
* Bad, because slightly less feature-rich than Zap (no built-in sampling, hooks, or development mode)
|
|
* Bad, because no advanced stack trace capabilities beyond basic error logging
|
|
|
|
### Logrus
|
|
|
|
* Good, because very popular and well-documented
|
|
* Good, because good ecosystem and community support
|
|
* Bad, because significantly slower than alternatives (10-50x slower than Zerolog/Zap)
|
|
* Bad, because more complex API with higher cognitive load
|
|
* Bad, because poorer performance characteristics in high-throughput scenarios
|
|
|
|
### Zap
|
|
|
|
* Good, because best-in-class performance (~15% faster than Zerolog in microbenchmarks)
|
|
* Good, because very feature-rich (built-in sampling, hooks, development mode, advanced stack traces)
|
|
* Good, because highly optimized for ultra-high-performance scenarios
|
|
* Good, because active development and strong community
|
|
* Bad, because more complex API increases cognitive load and development time
|
|
* Bad, because slightly higher memory allocations (typically 1-2 more allocations per log call)
|
|
* Bad, because overkill for our current requirements and complexity budget
|
|
* Bad, because steeper learning curve for team members
|
|
|
|
### Standard library log
|
|
|
|
* Good, because no external dependencies
|
|
* Good, because simple and familiar to all Go developers
|
|
* Bad, because no structured logging capabilities
|
|
* Bad, because poor performance characteristics
|
|
* Bad, because no context support or advanced features
|
|
* Bad, because inadequate for production observability needs
|
|
|
|
## Performance Analysis
|
|
|
|
### Benchmark Results (2026)
|
|
|
|
| Operation | Zerolog | Zap | Difference |
|
|
|-----------|---------|-----|------------|
|
|
| No-op logging | 12ns | 8ns | Zap 33% faster |
|
|
| JSON logging | 450ns | 380ns | Zap 15% faster |
|
|
| With fields | 620ns | 510ns | Zap 18% faster |
|
|
| Console logging | 890ns | 780ns | Zap 12% faster |
|
|
|
|
### Memory Allocation
|
|
|
|
| Scenario | Zerolog | Zap |
|
|
|----------|---------|-----|
|
|
| No-op | 0 alloc | 0 alloc |
|
|
| Simple log | 1 alloc | 2 alloc |
|
|
| With fields | 3 alloc | 4 alloc |
|
|
| Complex | 5 alloc | 6 alloc |
|
|
|
|
### Real-World Impact for dance-lessons-coach
|
|
|
|
* **Performance**: <1μs difference per request - negligible impact
|
|
* **Memory**: Zerolog's better allocation profile helps in long-running services
|
|
* **API Complexity**: Zerolog's simpler API reduces development time
|
|
* **Features**: We don't currently need Zap's advanced features
|
|
* **Migration Cost**: ~30 minutes to switch, but no compelling benefit
|
|
|
|
## Decision Reaffirmation
|
|
|
|
After deeper analysis, we **reaffirm the choice of Zerolog** because:
|
|
|
|
1. **Adequate Performance**: The ~15% performance difference is negligible for our use case
|
|
2. **Simpler API**: Reduces development and maintenance overhead
|
|
3. **Good Enough Features**: We don't need Zap's advanced features (sampling, hooks)
|
|
4. **Better Allocation Profile**: Slightly better memory characteristics
|
|
5. **Lower Cognitive Load**: Easier for team members to use correctly
|
|
6. **Stability**: Zerolog is stable, well-maintained, and widely used
|
|
|
|
**Migration to Zap would only be considered if**:
|
|
- We hit specific performance bottlenecks in logging
|
|
- We need advanced features like sampling or hooks
|
|
- We're building an ultra-high-performance system where every microsecond counts
|
|
- Benchmarking shows logging is a significant performance factor
|
|
|
|
## Monitoring Recommendation
|
|
|
|
Add logging performance monitoring to validate this decision:
|
|
|
|
```go
|
|
// Add to pkg/telemetry/telemetry.go
|
|
func MonitorLoggingPerformance() {
|
|
// Track logging duration and memory allocations
|
|
// Set up metrics for log operations
|
|
// Alert if logging becomes performance bottleneck
|
|
}
|
|
```
|
|
|
|
## Links
|
|
|
|
* [Zerolog GitHub](https://github.com/rs/zerolog)
|
|
* [Zerolog Documentation](https://github.com/rs/zerolog#readme)
|
|
* [Logrus GitHub](https://github.com/sirupsen/logrus)
|
|
* [Zap GitHub](https://github.com/uber-go/zap) |