Gabriel Radureau
8041a8c04f
Periodically delete magic-link tokens past their expires_at — the rows accumulate without cleanup since the consume endpoint only marks them consumed but never removes them, and DeleteExpiredMagicLinkTokens (added in Phase A.3, PR #61) was never wired up. Mirrors the JWT secret cleanup pattern (ADR-0021). - pkg/user/magic_link_cleanup.go: MagicLinkCleanupRunner with StartCleanupLoop(ctx, interval) and an inner runOnce(ctx) for testability - pkg/user/magic_link_cleanup_test.go: unit tests cover happy path, error propagation, ctx-cancel termination, zero-interval no-op - pkg/server/server.go: start the loop right after the JWT cleanup loop - pkg/config/config.go: auth.magic_link.cleanup_interval (default 1h), env DLC_AUTH_MAGIC_LINK_CLEANUP_INTERVAL, getter GetMagicLinkCleanupInterval Mostly authored by Mistral Vibe in batch1-task-b worktree (parallel with batch1-task-a OIDC config). Mistral hit --max-price 1.50 right before the final commit step, Claude finished the ship via trainer takeover (Q-045 pattern, 2nd recurrence in two batches — to be addressed in Phase 1bis).
65 lines
1.9 KiB
Go
65 lines
1.9 KiB
Go
package user
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type fakeMLRepo struct {
|
|
deleteN int64
|
|
deleteErr error
|
|
cutoffSeen time.Time
|
|
}
|
|
|
|
func (r *fakeMLRepo) CreateMagicLinkToken(_ context.Context, _ *MagicLinkToken) error { return nil }
|
|
func (r *fakeMLRepo) GetMagicLinkTokenByHash(_ context.Context, _ string) (*MagicLinkToken, error) {
|
|
return nil, nil
|
|
}
|
|
func (r *fakeMLRepo) MarkMagicLinkTokenConsumed(_ context.Context, _ uint, _ time.Time) error {
|
|
return nil
|
|
}
|
|
func (r *fakeMLRepo) DeleteExpiredMagicLinkTokens(_ context.Context, before time.Time) (int64, error) {
|
|
r.cutoffSeen = before
|
|
return r.deleteN, r.deleteErr
|
|
}
|
|
|
|
func TestRunOnce_ReturnsCount(t *testing.T) {
|
|
repo := &fakeMLRepo{deleteN: 7}
|
|
r := NewMagicLinkCleanupRunner(repo)
|
|
n, err := r.runOnce(context.Background())
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 7, n)
|
|
assert.WithinDuration(t, time.Now(), repo.cutoffSeen, time.Second)
|
|
}
|
|
|
|
func TestRunOnce_PropagatesError(t *testing.T) {
|
|
repo := &fakeMLRepo{deleteErr: errors.New("simulated")}
|
|
r := NewMagicLinkCleanupRunner(repo)
|
|
_, err := r.runOnce(context.Background())
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestStartCleanupLoop_StopsOnContextCancel(t *testing.T) {
|
|
repo := &fakeMLRepo{}
|
|
r := NewMagicLinkCleanupRunner(repo)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
r.StartCleanupLoop(ctx, 10*time.Millisecond)
|
|
time.Sleep(25 * time.Millisecond) // 2 ticks
|
|
cancel()
|
|
time.Sleep(15 * time.Millisecond) // give the goroutine time to exit
|
|
// Implicit assertion: no goroutine leak (test would hang in -race mode otherwise).
|
|
}
|
|
|
|
func TestStartCleanupLoop_NoOpWhenIntervalZero(t *testing.T) {
|
|
repo := &fakeMLRepo{}
|
|
r := NewMagicLinkCleanupRunner(repo)
|
|
r.StartCleanupLoop(context.Background(), 0)
|
|
// Just make sure no goroutine is started ; nothing observable to assert
|
|
// beyond "no panic, returns immediately".
|
|
}
|