arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

🐛 fix(frontend): apply server:false + route.fulfill to health spec #43

Merged
arcodange merged 1 commits from fix/health-spec-mock-route into main 2026-05-05 09:04:49 +02:00
Conversation 0 Commits 1 Files Changed 3 +23 -1
arcodange commented 2026-05-05 09:04:40 +02:00
Owner
Copy Link

Closes the debt left by PR #40. Same dev-proxy issue that the new app-footer spec worked around — applied here too. HealthDashboard.vue now fetches client-side only; health.spec.ts happy path now uses route mocking. Full Playwright suite (4 tests) green. Backend integration still covered by BDD.

Closes the debt left by PR #40. Same dev-proxy issue that the new app-footer spec worked around — applied here too. HealthDashboard.vue now fetches client-side only; health.spec.ts happy path now uses route mocking. Full Playwright suite (4 tests) green. Backend integration still covered by BDD.
arcodange added 1 commit 2026-05-05 09:04:41 +02:00
🐛 fix(frontend): apply server:false + route.fulfill to health spec
Some checks failed
CI/CD Pipeline / Build Docker Cache (push) Successful in 9s
Details
CI/CD Pipeline / CI Pipeline (push) Failing after 7m24s
Details
CI/CD Pipeline / Trigger Docker Push (push) Has been skipped
Details
262c4cfaed 
Closes the debt left by PR #40 (api/info + footer): the existing
tests/e2e/health.spec.ts happy path still hit the dev-proxy issue
that PR #40 worked around for the new app-footer spec.

Same fix applied to HealthDashboard.vue and the spec:
- HealthDashboard.vue: useFetch( ..., { server: false }) — fetch
  client-side only so Playwright route mocks apply (was failing on
  SSR through the dev proxy).
- health.spec.ts: happy path now uses page.route to mock /api/healthz
  with a 200 success body, matching the pattern in app-footer.spec.ts.
  The error scenario already used route mocking; unchanged.

The integration with the real backend remains covered by the BDD
scenario in features/health/health.feature (server-side, no proxy
in the loop).

Full Playwright suite (4 tests) now passes locally.
arcodange merged commit 4afc15b82e into main 2026-05-05 09:04:49 +02:00
arcodange deleted branch fix/health-spec-mock-route 2026-05-05 09:04:49 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
arcodange
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#43
Delete Branch "fix/health-spec-mock-route"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?