🐛 fix: emit all config-loading logs in correct JSON format from the start #16

Merged

arcodange merged 5 commits from fix/json-logging-first-message into main 2026-04-12 23:28:36 +02:00

Conversation 2 Commits 5 Files Changed 9

+313 -1620

5 Commits

Author	SHA1	Message	Date
arcodangeandClaude Sonnet 4.6	99b2e410f2	📝 docs: rewrite AGENTS.md and README.md for clarity and brevity ... Cut AGENTS.md from 1296 to ~210 lines: removed development timeline, changelog, stale AI agent section, verbose architecture examples, and duplicate content. Kept tech stack, project structure, key commands, config reference, API table, ADR index, and commit conventions. Cut README.md from 423 to ~80 lines: removed duplicate CI/CD sections (one had merge conflict markers), non-existent Cobra CLI and documentation/ references, and the AI agent usage section. Kept features, quick start, config table, API table, testing, and Gitea client setup. Also includes gitea-client.sh fixes from earlier session: create-pr sub-command and safe jq-based JSON body in comment-pr. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>	2026-04-12 20:18:25 +02:00
arcodangeandClaude Sonnet 4.6	18b2f0a87f	🔍 test: print formatted server log at end of graceful shutdown test ... Display the full log as a readable summary before cleanup so the complete server lifecycle is visible in test output without needing to preserve the log file manually. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>	2026-04-12 20:01:59 +02:00
arcodangeandClaude Sonnet 4.6	165e082eb9	🔍 test: show readiness HTTP response during shutdown window ... Print the full response body and status code from the /api/ready probe that fires during the graceful shutdown window, so the 200→503 transition is visible in test output rather than silently discarded. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>	2026-04-12 19:57:01 +02:00
arcodangeandClaude Sonnet 4.6	928fa9170c	🐛 fix: wire up readiness cancellation and stabilise graceful shutdown test ... Three related issues fixed together: 1. Readiness context was never cancelled during shutdown server.Run() had a type assertion for a Cancel() method that no standard context.Context implements, so readiness stayed "ready" through the entire shutdown window. Added CancelableContext to pkg/server — a thin wrapper that exposes Cancel() — and switched cmd/server/main.go to use it. Test servers and CLI continue passing context.Background() unchanged. 2. "Server exited" log was never emitted The test script expected it; main.go had no log after server.Run() returned. Added log.Trace().Msg("Server exited") after the Run() call. 3. Double-SIGTERM caused non-JSON "signal: terminated" in server.log test-graceful-shutdown.sh sent SIGTERM, then called $SERVER_CMD stop which sent a second SIGTERM. After signal.NotifyContext is cancelled, the second signal hits the default handler and Go prints "signal: terminated" to stderr, breaking the all-JSON-lines assertion. Fixed by waiting for the PID to exit ourselves instead of re-invoking the stop script. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>	2026-04-12 19:49:04 +02:00
arcodangeandClaude Sonnet 4.6	18ac000d30	🐛 fix: emit all config-loading logs in correct format from the start ... The logger was initialised to console format unconditionally, so the "Config file loaded" message (and similar early logs) were always written as human-readable text even when JSON logging was configured. Root cause: classic chicken-and-egg — the format flag lives inside the config that is being loaded. Fix: add peekJSONLogging() which resolves the format before any log is emitted by (1) checking DLC_LOGGING_JSON directly via os.Getenv, then (2) doing a minimal throwaway Viper pre-read of the config file for the logging.json key. The redundant format-switch block that ran after Unmarshal() is removed. Also add the "Logging configured" log as the very first line, and replace the hardcoded PROJECT_DIR path in start-server.sh, test-graceful-shutdown.sh, and test-opentelemetry.sh with a dynamic derivation from BASH_SOURCE[0]. Closes #15 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>	2026-04-12 19:25:06 +02:00