🔧 chore(config): defense-in-depth for WatchAndApply test race (Q-038) #50

arcodange · 2026-05-05T09:45:08+02:00

arcodange commented

2026-05-05 09:45:08 +02:00

Follow-up to PR #48. Adds TestMain to pkg/config that disables zerolog during the suite — sidesteps the race entirely without changing prod behavior. Also adds a longer code comment explaining WHY the log is intentionally absent. Race-clean across -count=2.

arcodange added 1 commit 2026-05-05 09:45:09 +02:00

🔧 chore(config): defense-in-depth for the WatchAndApply test race (Q-038)

CI/CD Pipeline / Build Docker Cache (push) Successful in 24s

Details

CI/CD Pipeline / CI Pipeline (push) Successful in 7m36s

Details

CI/CD Pipeline / Trigger Docker Push (push) Has been skipped

Details

189d44d70f

Follow-up to PR #48 after user question on whether mutex/atomic would be
a cleaner fix than removing the log call.

Honest answer: the racing memory location is zerolog's global gLevel,
which IS already mutated atomically by zerolog itself. The race detector
flags it because LoadConfig → SetupLogging writes gLevel via
zerolog.SetGlobalLevel and a leaked watcher goroutine reads gLevel via
log.Info() — both atomic individually, but go test -race treats the
write/read pair as a happens-before violation across goroutine
boundaries when there's no synchronization between them.

A mutex on Config would not help: the shared state isn't on Config,
it's on zerolog's package-level global. atomic.Pointer wouldn't help
for the same reason.

Combined fix:
1. Keep the log-removal (PR #48) — it's the actual race source: our
   cancel-handler goroutine's log.Info("watcher stopped") was the
   reading party. Add a longer comment explaining WHY it's gone.
2. Add pkg/config/main_test.go with TestMain that disables zerolog
   globally during the test suite. Defense in depth: any FUTURE
   leaked log call from a watcher-related goroutine won't trigger a
   race either, because no log call evaluates against the level.

Production behavior unchanged. SetupLogging in production runs once at
startup before any goroutine could race with it.

go test -race -count=2 ./pkg/config/... passes (was failing).

arcodange merged commit 46df1f6170 into main

2026-05-05 09:45:15 +02:00

arcodange deleted branch fix/config-test-main-quiet-zerolog

2026-05-05 09:45:15 +02:00

arcodange referenced this issue from a commit

2026-05-05 09:45:16 +02:00

🔧 chore(config): defense-in-depth for WatchAndApply test race (Q-038) (#50)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#50