arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

📝 docs: update ADR 0020 to reflect removal of certificate configuration step

Browse Source
This commit is contained in:
Gabriel Radureau
2026-04-07 11:59:00 +02:00
parent 6e2e9e3645
commit 91890659cf
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
adr/0020-docker-build-strategy.md
View File

@@ -215,12 +215,14 @@ ENTRYPOINT ["/app/dance-lessons-coach"]
jobs: jobs:
build-cache: build-cache:
# Builds Docker cache image if needed # Builds Docker cache image if needed
# Note: No certificate configuration needed with traditional docker
ci-pipeline: ci-pipeline:
needs: build-cache needs: build-cache
steps: steps:
- name: Set up build environment - name: Set up build environment
# Sets CACHE_IMAGE variable with proper tag # Sets CACHE_IMAGE variable with proper tag
# No Buildx setup, no Go installation, no certificate configuration
- name: Generate Swagger Docs using Docker cache - name: Generate Swagger Docs using Docker cache
# Uses: docker run ${{ env.CACHE_IMAGE }} sh -c "cd pkg/server && go generate" # Uses: docker run ${{ env.CACHE_IMAGE }} sh -c "cd pkg/server && go generate"
@@ -233,6 +235,7 @@ jobs:
- name: Build and push Docker image - name: Build and push Docker image
# Uses: docker build -t dance-lessons-coach -f Dockerfile.prod . # Uses: docker build -t dance-lessons-coach -f Dockerfile.prod .
# No Buildx, no certificate issues
``` ```
### Key Improvements ### Key Improvements
@@ -241,6 +244,8 @@ jobs:
2. **Consistent Environment**: All builds use the same Docker cache image 2. **Consistent Environment**: All builds use the same Docker cache image
3. **Reduced Complexity**: Simpler workflow with fewer steps 3. **Reduced Complexity**: Simpler workflow with fewer steps
4. **Better Error Handling**: Docker cache handles dependency management 4. **Better Error Handling**: Docker cache handles dependency management
5. **No Certificate Configuration**: Traditional docker works seamlessly with self-signed certificates
6. **Improved Reliability**: Elimination of Buildx-related failures
## Future Considerations ## Future Considerations
@@ -317,6 +322,7 @@ This decision prioritizes CI/CD reliability and simplicity over advanced feature
- [x] Keep `Dockerfile` for development use - [x] Keep `Dockerfile` for development use
- [x] Remove Docker Buildx from CI/CD workflow - [x] Remove Docker Buildx from CI/CD workflow
- [x] Remove Go build steps from CI/CD workflow - [x] Remove Go build steps from CI/CD workflow
- [x] Remove certificate configuration step (no longer needed)
- [x] Add Docker cache usage to all build steps - [x] Add Docker cache usage to all build steps
- [x] Update production Docker build to use `Dockerfile.prod` - [x] Update production Docker build to use `Dockerfile.prod`
- [x] Update ADR 0020 with comprehensive documentation - [x] Update ADR 0020 with comprehensive documentation