From 91890659cff18c78c152d0560cda62e088f9e5c9 Mon Sep 17 00:00:00 2001 From: Gabriel Radureau Date: Tue, 7 Apr 2026 11:59:00 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20docs:=20update=20ADR=200020=20to?= =?UTF-8?q?=20reflect=20removal=20of=20certificate=20configuration=20step?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- adr/0020-docker-build-strategy.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/adr/0020-docker-build-strategy.md b/adr/0020-docker-build-strategy.md index c1d5061..bcb6a5b 100644 --- a/adr/0020-docker-build-strategy.md +++ b/adr/0020-docker-build-strategy.md @@ -215,12 +215,14 @@ ENTRYPOINT ["/app/dance-lessons-coach"] jobs: build-cache: # Builds Docker cache image if needed + # Note: No certificate configuration needed with traditional docker ci-pipeline: needs: build-cache steps: - name: Set up build environment # Sets CACHE_IMAGE variable with proper tag + # No Buildx setup, no Go installation, no certificate configuration - name: Generate Swagger Docs using Docker cache # Uses: docker run ${{ env.CACHE_IMAGE }} sh -c "cd pkg/server && go generate" @@ -233,6 +235,7 @@ jobs: - name: Build and push Docker image # Uses: docker build -t dance-lessons-coach -f Dockerfile.prod . + # No Buildx, no certificate issues ``` ### Key Improvements @@ -241,6 +244,8 @@ jobs: 2. **Consistent Environment**: All builds use the same Docker cache image 3. **Reduced Complexity**: Simpler workflow with fewer steps 4. **Better Error Handling**: Docker cache handles dependency management +5. **No Certificate Configuration**: Traditional docker works seamlessly with self-signed certificates +6. **Improved Reliability**: Elimination of Buildx-related failures ## Future Considerations @@ -317,6 +322,7 @@ This decision prioritizes CI/CD reliability and simplicity over advanced feature - [x] Keep `Dockerfile` for development use - [x] Remove Docker Buildx from CI/CD workflow - [x] Remove Go build steps from CI/CD workflow +- [x] Remove certificate configuration step (no longer needed) - [x] Add Docker cache usage to all build steps - [x] Update production Docker build to use `Dockerfile.prod` - [x] Update ADR 0020 with comprehensive documentation