📝 docs: update ADR 0020 to reflect removal of certificate configuration step
This commit is contained in:
@@ -215,12 +215,14 @@ ENTRYPOINT ["/app/dance-lessons-coach"]
|
||||
jobs:
|
||||
build-cache:
|
||||
# Builds Docker cache image if needed
|
||||
# Note: No certificate configuration needed with traditional docker
|
||||
|
||||
ci-pipeline:
|
||||
needs: build-cache
|
||||
steps:
|
||||
- name: Set up build environment
|
||||
# Sets CACHE_IMAGE variable with proper tag
|
||||
# No Buildx setup, no Go installation, no certificate configuration
|
||||
|
||||
- name: Generate Swagger Docs using Docker cache
|
||||
# Uses: docker run ${{ env.CACHE_IMAGE }} sh -c "cd pkg/server && go generate"
|
||||
@@ -233,6 +235,7 @@ jobs:
|
||||
|
||||
- name: Build and push Docker image
|
||||
# Uses: docker build -t dance-lessons-coach -f Dockerfile.prod .
|
||||
# No Buildx, no certificate issues
|
||||
```
|
||||
|
||||
### Key Improvements
|
||||
@@ -241,6 +244,8 @@ jobs:
|
||||
2. **Consistent Environment**: All builds use the same Docker cache image
|
||||
3. **Reduced Complexity**: Simpler workflow with fewer steps
|
||||
4. **Better Error Handling**: Docker cache handles dependency management
|
||||
5. **No Certificate Configuration**: Traditional docker works seamlessly with self-signed certificates
|
||||
6. **Improved Reliability**: Elimination of Buildx-related failures
|
||||
|
||||
## Future Considerations
|
||||
|
||||
@@ -317,6 +322,7 @@ This decision prioritizes CI/CD reliability and simplicity over advanced feature
|
||||
- [x] Keep `Dockerfile` for development use
|
||||
- [x] Remove Docker Buildx from CI/CD workflow
|
||||
- [x] Remove Go build steps from CI/CD workflow
|
||||
- [x] Remove certificate configuration step (no longer needed)
|
||||
- [x] Add Docker cache usage to all build steps
|
||||
- [x] Update production Docker build to use `Dockerfile.prod`
|
||||
- [x] Update ADR 0020 with comprehensive documentation
|
||||
|
||||
Reference in New Issue
Block a user