🐛 fix(ci): remove dollar-double-brace expression from comment that still gets interpolated (#47)
Co-authored-by: Gabriel Radureau <arcodange@gmail.com> Co-committed-by: Gabriel Radureau <arcodange@gmail.com>
This commit was merged in pull request #47.
This commit is contained in:
@@ -299,10 +299,11 @@ jobs:
|
||||
# Check for version bump on main branch
|
||||
if [ "${{ github.ref }}" = "refs/heads/main" ]; then
|
||||
echo "🔖 Checking for version bump..."
|
||||
# Always read from git log: ${{ github.event.head_commit.message }} expression
|
||||
# is interpolated literally into the shell script, so any backtick, unbalanced
|
||||
# quote, or special char in a commit body breaks the next line of the script
|
||||
# (observed on PR #32-#35: 'syntax error: unexpected newline'). git log is safe.
|
||||
# Read commit message from git, NOT from the workflow event payload.
|
||||
# The event-payload expression is interpolated literally into the
|
||||
# rendered script (even inside comments — see PR #38 + #46), so any
|
||||
# backtick / unbalanced quote / multi-line body breaks bash parsing.
|
||||
# git log is interpolation-free and safe.
|
||||
COMMIT_MSG=$(git log -1 --pretty=%B)
|
||||
./scripts/ci-version-bump.sh "$COMMIT_MSG" --no-push
|
||||
fi
|
||||
|
||||
Reference in New Issue
Block a user