From cc970e1f533f9b7995ca46aeb952f5b3ca5d41e2 Mon Sep 17 00:00:00 2001 From: Vanilagy <1696106+Vanilagy@users.noreply.github.com> Date: Fri, 3 Jul 2026 16:24:08 +0200 Subject: [PATCH] Fix invalid check for no available read worker stalling reads, bump patch --- package-lock.json | 18 +++++++++--------- package.json | 2 +- packages/aac-encoder/package.json | 2 +- packages/ac3/package.json | 2 +- packages/flac-encoder/package.json | 2 +- packages/mp3-encoder/package.json | 2 +- packages/prores/package.json | 2 +- packages/server/package.json | 4 ++-- src/source.ts | 10 +++++++--- 9 files changed, 24 insertions(+), 20 deletions(-) diff --git a/package-lock.json b/package-lock.json index e320db2..2afd845 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "mediabunny", - "version": "1.50.4", + "version": "1.50.5", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "mediabunny", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "workspaces": [ ".", @@ -12894,7 +12894,7 @@ }, "packages/aac-encoder": { "name": "@mediabunny/aac-encoder", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "devDependencies": { "@types/emscripten": "^1.40.1" @@ -12909,7 +12909,7 @@ }, "packages/ac3": { "name": "@mediabunny/ac3", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "devDependencies": { "@types/emscripten": "^1.40.1" @@ -12924,7 +12924,7 @@ }, "packages/flac-encoder": { "name": "@mediabunny/flac-encoder", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "devDependencies": { "@types/emscripten": "^1.40.1" @@ -12939,7 +12939,7 @@ }, "packages/mp3-encoder": { "name": "@mediabunny/mp3-encoder", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "devDependencies": { "@types/emscripten": "^1.40.1" @@ -12954,7 +12954,7 @@ }, "packages/prores": { "name": "@mediabunny/prores", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "dependencies": { "turbores": "^1.2.1" @@ -12969,10 +12969,10 @@ }, "packages/server": { "name": "@mediabunny/server", - "version": "1.50.4", + "version": "1.50.5", "license": "MPL-2.0", "dependencies": { - "@mediabunny/prores": "^1.50.0", + "@mediabunny/prores": "^1.50.4", "node-av": "^6.0.0" }, "funding": { diff --git a/package.json b/package.json index 3947b40..465cf77 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "mediabunny", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "Pure TypeScript media toolkit for reading, writing, and converting media files, directly in the browser.", "type": "module", "workspaces": [ diff --git a/packages/aac-encoder/package.json b/packages/aac-encoder/package.json index 3deca77..02630df 100644 --- a/packages/aac-encoder/package.json +++ b/packages/aac-encoder/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/aac-encoder", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "AAC encoder extension for Mediabunny, based on FFmpeg.", "main": "./dist/bundles/mediabunny-aac-encoder.mjs", "module": "./dist/bundles/mediabunny-aac-encoder.mjs", diff --git a/packages/ac3/package.json b/packages/ac3/package.json index a4d430a..5e939f1 100644 --- a/packages/ac3/package.json +++ b/packages/ac3/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/ac3", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "AC-3 and E-AC-3 (Dolby Digital) decoder and encoder extension for Mediabunny, based on FFmpeg.", "main": "./dist/bundles/mediabunny-ac3.mjs", "module": "./dist/bundles/mediabunny-ac3.mjs", diff --git a/packages/flac-encoder/package.json b/packages/flac-encoder/package.json index 7fa7cfb..e31cba9 100644 --- a/packages/flac-encoder/package.json +++ b/packages/flac-encoder/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/flac-encoder", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "FLAC encoder extension for Mediabunny, based on libFLAC.", "main": "./dist/bundles/mediabunny-flac-encoder.mjs", "module": "./dist/bundles/mediabunny-flac-encoder.mjs", diff --git a/packages/mp3-encoder/package.json b/packages/mp3-encoder/package.json index 625ca51..1b06a01 100644 --- a/packages/mp3-encoder/package.json +++ b/packages/mp3-encoder/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/mp3-encoder", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "MP3 encoder extension for Mediabunny, based on LAME.", "main": "./dist/bundles/mediabunny-mp3-encoder.mjs", "module": "./dist/bundles/mediabunny-mp3-encoder.mjs", diff --git a/packages/prores/package.json b/packages/prores/package.json index 177ce00..8b436b9 100644 --- a/packages/prores/package.json +++ b/packages/prores/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/prores", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "Apple ProRes decoder extension for Mediabunny, based on TurboRes.", "main": "./dist/bundles/mediabunny-prores.mjs", "module": "./dist/bundles/mediabunny-prores.mjs", diff --git a/packages/server/package.json b/packages/server/package.json index 7c7cd0f..c441dd3 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -1,7 +1,7 @@ { "name": "@mediabunny/server", "author": "Vanilagy", - "version": "1.50.4", + "version": "1.50.5", "description": "Adds full video and audio decoder and encoder support to Mediabunny for use in server-side environments (Node, Bun, Deno). Based on NodeAV.", "main": "./dist/bundles/mediabunny-server.cjs", "module": "./dist/bundles/mediabunny-server.mjs", @@ -35,7 +35,7 @@ }, "dependencies": { "node-av": "^6.0.0", - "@mediabunny/prores": "^1.50.4" + "@mediabunny/prores": "^1.50.5" }, "peerDependencies": { "mediabunny": "^1.45.0" diff --git a/src/source.ts b/src/source.ts index ea56e37..4192d9b 100644 --- a/src/source.ts +++ b/src/source.ts @@ -2129,7 +2129,7 @@ class ReadOrchestrator { } }) .finally(() => { - if (worker.running || this.workers.length >= this.options.maxWorkerCount) { + if (worker.running) { // Rare, but can happen with multiple concurrent reads. In this case, don't do anything. return; } @@ -2144,15 +2144,19 @@ class ReadOrchestrator { } const queuedRead = this.queuedReads[oldestIndex]!; - this.queuedReads.splice(oldestIndex, 1); const newWorker = this.createWorker( queuedRead.hole.start, queuedRead.hole.end, queuedRead.strictTarget, ); - assert(newWorker); // We just freed up a worker, so this should never fail + if (!newWorker) { + // In high-contention cases, it could be that we've already reached max worker count, so in this + // case we don't do anything. + return; + } + this.queuedReads.splice(oldestIndex, 1); newWorker.pendingSlices = queuedRead.pendingSlices; this.runWorker(newWorker); }