arcodange/mediabunny
1
0
Fork 0
mirror of https://github.com/arcodange-org/mediabunny.git synced 2026-10-01 21:03:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix some bugs & polish edge cases

Browse Source
This commit is contained in:
Vanilagy
2026-05-11 23:50:06 +02:00
parent d8c8606341
commit 81531cc510
8 changed files with 92 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/video-encoder.ts
+23 -5
View File
@@ -1,4 +1,12 @@
import { CustomVideoEncoder, MaybePromise, QUALITY_MEDIUM, VideoCodec, VideoSample, EncodedPacket } from 'mediabunny';
import {
CustomVideoEncoder,
MaybePromise,
QUALITY_MEDIUM,
VideoCodec,
VideoSample,
EncodedPacket,
EncodedPacketSideData,
} from 'mediabunny';
import * as NodeAv from 'node-av';
import {
CODEC_TO_CODEC_ID,
@@ -25,7 +33,6 @@ import {
} from '../../../src/codec-data';
import { extractVideoCodecString } from '../../../src/codec';
import { assert, binarySearchLessOrEqual, simplifyRational, toUint8Array } from '../../../src/misc';
import { EncodedPacketSideData } from 'mediabunny';
export class NodeAvVideoEncoder extends CustomVideoEncoder {
frame!: NodeAv.Frame;
@@ -180,7 +187,6 @@ export class NodeAvVideoEncoder extends CustomVideoEncoder {
}
this.lastBuffer = await copyVideoSampleToAvFrame(videoSample, this.frame, this.lastBuffer);
this.frame.keyFrame = options?.keyFrame ? 1 : 0;
}
let frameToEncode = this.frame;
@@ -225,6 +231,18 @@ export class NodeAvVideoEncoder extends CustomVideoEncoder {
frameToEncode = this.dstFrame;
}
frameToEncode.pts = BigInt(videoSample.microsecondTimestamp);
frameToEncode.duration = BigInt(videoSample.microsecondDuration);
frameToEncode.timeBase = new NodeAv.Rational(1, 1e6);
// Let's just set both for good measure
frameToEncode.pictType = options?.keyFrame
? NodeAv.AV_PICTURE_TYPE_I
: NodeAv.AV_PICTURE_TYPE_NONE;
frameToEncode.keyFrame = options?.keyFrame
? 1
: 0;
const preciseTimingIndex = binarySearchLessOrEqual(
this.preciseTimings,
videoSample.microsecondTimestamp,
@@ -503,8 +521,8 @@ export class NodeAvVideoEncoder extends CustomVideoEncoder {
};
}
this.onPacket(packet, metadata);
this.packetEmitted = true;
this.onPacket(packet, metadata);
}
async flush(): Promise<void> {
@@ -525,7 +543,7 @@ export class NodeAvVideoEncoder extends CustomVideoEncoder {
this.codecContext.freeContext();
this.codecContext = null;
// The codec is done now and can't be reused. Any subsequence encode call will first need to recreate a
// The codec is done now and can't be reused. Any subsequent encode call will first need to recreate a
// codec context.
}