Remove superfluous end pos seeks, fix validation bug

This commit is contained in:
Vanilagy
2026-03-27 21:29:47 +01:00
parent 94678dd356
commit 7b70756961
5 changed files with 2 additions and 11 deletions
-4
View File
@@ -1332,8 +1332,6 @@ export class MatroskaMuxer extends Muxer {
this.ebmlWriter.writeEBML(this.cues); this.ebmlWriter.writeEBML(this.cues);
if (!this.format._options.appendOnly) { if (!this.format._options.appendOnly) {
const endPos = this.writer.getPos();
// Write the Segment size // Write the Segment size
const segmentSize = this.writer.getPos() - this.segmentDataOffset; const segmentSize = this.writer.getPos() - this.segmentDataOffset;
this.writer.seek(this.ebmlWriter.offsets.get(this.segment!)! + 4); this.writer.seek(this.ebmlWriter.offsets.get(this.segment!)! + 4);
@@ -1352,8 +1350,6 @@ export class MatroskaMuxer extends Muxer {
this.writer.seek(this.ebmlWriter.offsets.get(this.seekHead)!); this.writer.seek(this.ebmlWriter.offsets.get(this.seekHead)!);
this.maybeCreateSeekHead(true); this.maybeCreateSeekHead(true);
this.ebmlWriter.writeEBML(this.seekHead); this.ebmlWriter.writeEBML(this.seekHead);
this.writer.seek(endPos);
} }
release(); release();
-2
View File
@@ -164,8 +164,6 @@ export class Mp3Muxer extends Muxer {
this.format._options.onXingFrame(data, start); this.format._options.onXingFrame(data, start);
} }
this.writer.seek(endPos);
release(); release();
} }
} }
+1 -1
View File
@@ -49,7 +49,7 @@ export abstract class Target {
onfinalized: (() => unknown) | null = null; onfinalized: (() => unknown) | null = null;
slice(offset: number) { slice(offset: number) {
if (!Number.isInteger(offset) && offset < 0) { if (!Number.isInteger(offset) || offset < 0) {
throw new TypeError('offset must be a non-negative integer.'); throw new TypeError('offset must be a non-negative integer.');
} }
-2
View File
@@ -369,8 +369,6 @@ export class WaveMuxer extends Muxer {
this.riffWriter.writeU32(this.dataSize); this.riffWriter.writeU32(this.dataSize);
} }
this.writer.seek(endPos);
release(); release();
} }
} }
-1
View File
@@ -7,4 +7,3 @@ Also, why not just have the packet metadata on the packet? I think that would ma
- Add an HLS "live mode". Challenge, where does bitrate come from? - Add an HLS "live mode". Challenge, where does bitrate come from?
- fmp4 muxing (CMAF??) - fmp4 muxing (CMAF??)
- ext-x-i-frames-only writing