arcodange/mediabunny
1
0
Fork 0
mirror of https://github.com/arcodange-org/mediabunny.git synced 2026-10-02 21:33:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add BlobSourceOptions.useStreamReader (#179)

Browse Source
This commit is contained in:
Vanilagy
2026-05-04 14:20:21 +02:00
parent 8955ba70c2
commit 47ad5c6806
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/source.ts
+14 -1
View File
@@ -443,6 +443,12 @@ export class BufferSource extends Source {
export type BlobSourceOptions = { export type BlobSourceOptions = {
/** The maximum number of bytes the cache is allowed to hold in memory. Defaults to 8 MiB. */ /** The maximum number of bytes the cache is allowed to hold in memory. Defaults to 8 MiB. */
maxCacheSize?: number; maxCacheSize?: number;
/**
* Defaults to `true`. When `true`, Mediabunny will acquire a `ReadableStream` reader internally to efficiently read
* data from the blob. Since this can lead to errors in some (very) rare cases due to browser bugs, you can set this
* field to `false` to try a slower but more stable reading method.
*/
useStreamReader?: boolean;
}; };
/** /**
@@ -456,6 +462,8 @@ export class BlobSource extends Source {
/** @internal */ /** @internal */
_blob: Blob; _blob: Blob;
/** @internal */ /** @internal */
_options: BlobSourceOptions;
/** @internal */
_orchestrator: ReadOrchestrator; _orchestrator: ReadOrchestrator;
/** /**
@@ -475,10 +483,15 @@ export class BlobSource extends Source {
) { ) {
throw new TypeError('options.maxCacheSize, when provided, must be a non-negative number.'); throw new TypeError('options.maxCacheSize, when provided, must be a non-negative number.');
} }
if (options.useStreamReader !== undefined && typeof options.useStreamReader !== 'boolean') {
throw new TypeError('options.useStreamReader, when provided, must be a boolean.');
}
super(); super();
this._blob = blob; this._blob = blob;
this._options = options;
this._orchestrator = new ReadOrchestrator({ this._orchestrator = new ReadOrchestrator({
maxCacheSize: options.maxCacheSize ?? (8 * 2 ** 20 /* 8 MiB */), maxCacheSize: options.maxCacheSize ?? (8 * 2 ** 20 /* 8 MiB */),
maxWorkerCount: 4, maxWorkerCount: 4,
@@ -520,7 +533,7 @@ export class BlobSource extends Source {
// - ReadableStream stalls under backpressure (especially video) // - ReadableStream stalls under backpressure (especially video)
// Affects Safari and all iOS browsers (Chrome, Firefox, etc.). // Affects Safari and all iOS browsers (Chrome, Firefox, etc.).
// Use arrayBuffer() fallback for WebKit browsers. // Use arrayBuffer() fallback for WebKit browsers.
if ('stream' in this._blob && !isWebKit()) { if ('stream' in this._blob && !isWebKit() && this._options.useStreamReader !== false) {
// Get a reader of the blob starting at the required offset, and then keep it around // Get a reader of the blob starting at the required offset, and then keep it around
const slice = this._blob.slice(worker.currentPos); const slice = this._blob.slice(worker.currentPos);
reader = slice.stream().getReader(); reader = slice.stream().getReader();