From 060ceb8ed36547a4f493408511610c8f447a0e64 Mon Sep 17 00:00:00 2001 From: Vanilagy <1696106+Vanilagy@users.noreply.github.com> Date: Tue, 12 May 2026 00:43:08 +0200 Subject: [PATCH] Fix tests some more --- test/browser/flac-encoder-extension.test.ts | 1 + test/node/aac-encoder-extension.test.ts | 12 +++++++---- test/node/ac3.test.ts | 24 ++++++++++++++------- test/node/flac-encoder-extension.test.ts | 12 +++++++---- test/node/mp3-encoder-extension.test.ts | 12 +++++++---- test/node/server-extension.test.ts | 4 ++++ 6 files changed, 45 insertions(+), 20 deletions(-) diff --git a/test/browser/flac-encoder-extension.test.ts b/test/browser/flac-encoder-extension.test.ts index b75ae02..0462b9c 100644 --- a/test/browser/flac-encoder-extension.test.ts +++ b/test/browser/flac-encoder-extension.test.ts @@ -88,6 +88,7 @@ const encodeAndDecodeFirstSample = async (audioSample: AudioSample) => { await output.start(); await audioSource.add(audioSample); + audioSample.close(); audioSource.close(); await output.finalize(); diff --git a/test/node/aac-encoder-extension.test.ts b/test/node/aac-encoder-extension.test.ts index 5f29a34..9679c12 100644 --- a/test/node/aac-encoder-extension.test.ts +++ b/test/node/aac-encoder-extension.test.ts @@ -51,13 +51,15 @@ test('AAC encoding', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp: 0, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -100,13 +102,15 @@ test('AAC with huge timestamps', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); diff --git a/test/node/ac3.test.ts b/test/node/ac3.test.ts index bafea2c..7b5638a 100644 --- a/test/node/ac3.test.ts +++ b/test/node/ac3.test.ts @@ -252,13 +252,15 @@ test('AC-3 encoding', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp: 0, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -300,13 +302,15 @@ test('E-AC-3 encoding', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp: 0, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -350,13 +354,15 @@ test('AC-3 with huge timestamps', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -399,13 +405,15 @@ test('E-AC-3 with huge timestamps', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); diff --git a/test/node/flac-encoder-extension.test.ts b/test/node/flac-encoder-extension.test.ts index 2010ff3..b39a1ce 100644 --- a/test/node/flac-encoder-extension.test.ts +++ b/test/node/flac-encoder-extension.test.ts @@ -51,13 +51,15 @@ test('FLAC encoding', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp: 0, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -101,13 +103,15 @@ test('FLAC with huge timestamps', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); diff --git a/test/node/mp3-encoder-extension.test.ts b/test/node/mp3-encoder-extension.test.ts index 15848d7..4b3e58d 100644 --- a/test/node/mp3-encoder-extension.test.ts +++ b/test/node/mp3-encoder-extension.test.ts @@ -51,13 +51,15 @@ test('MP3 encoding', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp: 0, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); @@ -101,13 +103,15 @@ test('MP3 with huge timestamps', async () => { output.addAudioTrack(audioSource); await output.start(); - await audioSource.add(new AudioSample({ + const sample = new AudioSample({ data, format: 'f32', numberOfChannels: channels, sampleRate, timestamp, - })); + }); + await audioSource.add(sample); + sample.close(); audioSource.close(); await output.finalize(); diff --git a/test/node/server-extension.test.ts b/test/node/server-extension.test.ts index 0553c35..a9077a6 100644 --- a/test/node/server-extension.test.ts +++ b/test/node/server-extension.test.ts @@ -626,6 +626,10 @@ describe('Video', async () => { const packetSink = new EncodedPacketSink(inputTrack); for await (const packet of packetSink.packets()) { + if (duration !== undefined && packet.timestamp >= duration) { + break; + } + packetTimestamps.push(packet.timestamp); }