Gabriel Radureau
8041a8c04f
Periodically delete magic-link tokens past their expires_at — the rows accumulate without cleanup since the consume endpoint only marks them consumed but never removes them, and DeleteExpiredMagicLinkTokens (added in Phase A.3, PR #61) was never wired up. Mirrors the JWT secret cleanup pattern (ADR-0021). - pkg/user/magic_link_cleanup.go: MagicLinkCleanupRunner with StartCleanupLoop(ctx, interval) and an inner runOnce(ctx) for testability - pkg/user/magic_link_cleanup_test.go: unit tests cover happy path, error propagation, ctx-cancel termination, zero-interval no-op - pkg/server/server.go: start the loop right after the JWT cleanup loop - pkg/config/config.go: auth.magic_link.cleanup_interval (default 1h), env DLC_AUTH_MAGIC_LINK_CLEANUP_INTERVAL, getter GetMagicLinkCleanupInterval Mostly authored by Mistral Vibe in batch1-task-b worktree (parallel with batch1-task-a OIDC config). Mistral hit --max-price 1.50 right before the final commit step, Claude finished the ship via trainer takeover (Q-045 pattern, 2nd recurrence in two batches — to be addressed in Phase 1bis).
57 lines
1.5 KiB
Go
57 lines
1.5 KiB
Go
package user
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
// MagicLinkCleanupRunner periodically deletes expired magic-link tokens
|
|
// (ADR-0028 Phase A consequence — the rows accumulate without cleanup
|
|
// otherwise, and stale rows are pure overhead since the token plaintext
|
|
// is never stored).
|
|
type MagicLinkCleanupRunner struct {
|
|
repo MagicLinkRepository
|
|
}
|
|
|
|
// NewMagicLinkCleanupRunner creates a new cleanup runner.
|
|
func NewMagicLinkCleanupRunner(repo MagicLinkRepository) *MagicLinkCleanupRunner {
|
|
return &MagicLinkCleanupRunner{repo: repo}
|
|
}
|
|
|
|
// StartCleanupLoop runs the cleanup pass every `interval`. Stops when ctx
|
|
// is cancelled. interval <= 0 disables the loop.
|
|
func (r *MagicLinkCleanupRunner) StartCleanupLoop(ctx context.Context, interval time.Duration) {
|
|
if interval <= 0 {
|
|
return
|
|
}
|
|
go func() {
|
|
ticker := time.NewTicker(interval)
|
|
defer ticker.Stop()
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case <-ticker.C:
|
|
_, _ = r.runOnce(ctx)
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
// runOnce performs a single cleanup pass. Returns the count of deleted rows.
|
|
// Exposed for testing — tests drive runOnce directly instead of waiting on
|
|
// the ticker.
|
|
func (r *MagicLinkCleanupRunner) runOnce(ctx context.Context) (int64, error) {
|
|
n, err := r.repo.DeleteExpiredMagicLinkTokens(ctx, time.Now())
|
|
if err != nil {
|
|
log.Error().Ctx(ctx).Err(err).Msg("magic-link cleanup: delete failed")
|
|
return 0, err
|
|
}
|
|
if n > 0 {
|
|
log.Trace().Ctx(ctx).Int64("deleted", n).Msg("magic-link cleanup: removed expired tokens")
|
|
}
|
|
return n, nil
|
|
}
|