arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

📝 docs(adr): close 5 partial ADRs with code-confirmed status updates #39

Merged
arcodange merged 1 commits from docs/homogenize-partial-adrs into main 2026-05-05 08:07:09 +02:00
Conversation 0 Commits 1 Files Changed 5 +28 -28
arcodange commented 2026-05-05 08:07:02 +02:00
Owner
Copy Link

Sprint 1 of autonomous trainer day 2026-05-05 (warm-up: docs sweep)

Verifier skill Dim B (docs homogeneity + code↔docs confrontation) flagged 5 ADRs marked Partially Implemented while the corresponding code is live in main. This PR reconciles each ADR's Status field with the actual implementation state.

Per-ADR audit + decision

ADR Was Now Code evidence
0009 (Hybrid testing) Partially Implemented (BDD + Documentation only) Implemented; SDK gen explicitly out of scope features/, pkg/bdd/, swagger annotations ; no SDK gen tooling found
0013 (OpenAPI toolchain) Partially Implemented Implemented; SDK gen out of scope (xref ADR-0009) swag CLI in pre-commit hooks ; httpSwagger.WrapHandler at /swagger/
0018 (User auth) Partially Implemented Implemented pkg/user/ (user.go, jwt_manager, postgres_repository, sqlite_repository, auth_service) + pkg/user/api/ (auth_handler, user_handler, password_handler, admin_handler) + features/auth/user_authentication.feature + greet personalization in pkg/greet/greet.go
0019 (Postgres) Partially Implemented Implemented (core); per-item: CI ✅, perf+monitoring deferred postgres:15 service in .gitea/workflows/ci-cd.yaml ; pkg/user/postgres_repository.go ; healthz reports DB connectivity
0024 (BDD test org) Partially Implemented Implemented Phase 1+2+3 features// layout ; pkg/bdd/testserver/ ; PR #35 closed Phase 3 with schema-per-package isolation, 2.85x speedup ; strategy in ADR-0025

What this PR is NOT

  • No code changes — pure status reconciliation
  • No new ADRs — future enhancements (2FA, query optim, perf monitoring) belong in their own ADRs if/when reopened
  • No deletion of any ADR section — "Future Considerations" / "Long-Term Enhancements" sections preserved as aspirational backlog

Verifier verdict (Dim B manual run before PR)

  • Status headers consistent across all 5 ADRs (all Implemented (...) with parenthesized scope clarification)
  • Cross-references valid: ADR-0024 → ADR-0025 ; ADR-0013 → ADR-0009 ; ADR-0024 → documentation/BDD_TEST_ENV.md
  • PR #35 link uses internal Gitea URL (correct domain arcodange.lab per repo conventions)
  • No broken markdown links

Verdict : APPROVE

Why this matters for the autonomy story

The "Partially Implemented" pile was the loudest signal that the project ships value but doesn't close ADR loops. Closing that pile means:

  1. Future verifier runs won't flag these as drift (false positives down)
  2. Active work is visible (open Proposed ADRs are the real backlog: 0021 JWT rotation, 0023 hot reload)
  3. Mistral-driven autonomous PRs can rely on Status as ground truth when scoping a feature

Next sprint stories already queued: feat: /api/info aggregator + frontend version footer (Mistral autonomous via ICM workspace) and feat: ADR-0021 JWT secret rotation (Mistral, substantive).

## Sprint 1 of autonomous trainer day 2026-05-05 (warm-up: docs sweep) Verifier skill Dim B (docs homogeneity + code↔docs confrontation) flagged 5 ADRs marked **Partially Implemented** while the corresponding code is live in main. This PR reconciles each ADR's `Status` field with the actual implementation state. ## Per-ADR audit + decision | ADR | Was | Now | Code evidence | |---|---|---|---| | 0009 (Hybrid testing) | Partially Implemented (BDD + Documentation only) | Implemented; SDK gen explicitly out of scope | features/, pkg/bdd/, swagger annotations ; no SDK gen tooling found | | 0013 (OpenAPI toolchain) | Partially Implemented | Implemented; SDK gen out of scope (xref ADR-0009) | swag CLI in pre-commit hooks ; httpSwagger.WrapHandler at /swagger/ | | 0018 (User auth) | Partially Implemented | Implemented | pkg/user/ (user.go, jwt_manager, postgres_repository, sqlite_repository, auth_service) + pkg/user/api/ (auth_handler, user_handler, password_handler, admin_handler) + features/auth/user_authentication.feature + greet personalization in pkg/greet/greet.go | | 0019 (Postgres) | Partially Implemented | Implemented (core); per-item: CI ✅, perf+monitoring deferred | postgres:15 service in .gitea/workflows/ci-cd.yaml ; pkg/user/postgres_repository.go ; healthz reports DB connectivity | | 0024 (BDD test org) | Partially Implemented | Implemented Phase 1+2+3 | features/<domain>/ layout ; pkg/bdd/testserver/ ; PR #35 closed Phase 3 with schema-per-package isolation, 2.85x speedup ; strategy in ADR-0025 | ## What this PR is NOT - No code changes — pure status reconciliation - No new ADRs — future enhancements (2FA, query optim, perf monitoring) belong in their own ADRs if/when reopened - No deletion of any ADR section — "Future Considerations" / "Long-Term Enhancements" sections preserved as aspirational backlog ## Verifier verdict (Dim B manual run before PR) - Status headers consistent across all 5 ADRs (all `Implemented (...)` with parenthesized scope clarification) - Cross-references valid: ADR-0024 → ADR-0025 ; ADR-0013 → ADR-0009 ; ADR-0024 → `documentation/BDD_TEST_ENV.md` - PR #35 link uses internal Gitea URL (correct domain `arcodange.lab` per repo conventions) - No broken markdown links **Verdict** : APPROVE ## Why this matters for the autonomy story The "Partially Implemented" pile was the loudest signal that the project ships value but doesn't close ADR loops. Closing that pile means: 1. Future verifier runs won't flag these as drift (false positives down) 2. Active work is visible (open Proposed ADRs are the real backlog: 0021 JWT rotation, 0023 hot reload) 3. Mistral-driven autonomous PRs can rely on Status as ground truth when scoping a feature Next sprint stories already queued: `feat: /api/info aggregator + frontend version footer` (Mistral autonomous via ICM workspace) and `feat: ADR-0021 JWT secret rotation` (Mistral, substantive).
arcodange added 1 commit 2026-05-05 08:07:03 +02:00
📝 docs(adr): close 5 partial ADRs with code-confirmed status updates 035e49ae80 
Verifier Dim B (homogeneity + code↔docs confrontation) flagged 5 ADRs
stuck at "Partially Implemented" while the corresponding code is live.
Audit + status update:

- ADR-0009 (Hybrid testing) → Implemented; SDK gen explicitly out of scope
- ADR-0013 (OpenAPI toolchain) → Implemented; SDK gen explicitly out of
  scope, cross-refs ADR-0009
- ADR-0018 (User auth) → Implemented; user model, JWT auth, password
  reset, admin endpoints, greet personalization, BDD coverage all live
  (verified in pkg/user/, pkg/auth/, features/auth/)
- ADR-0019 (Postgres) → Implemented (core); per-item next-steps audit:
  CI integration ✅, performance tuning + monitoring tracked separately
- ADR-0024 (BDD test org) → Implemented Phase 1+2+3; PR #35 closed
  Phase 3 parallel testing with 2.85x speedup, strategy in ADR-0025

No code changes — pure status reconciliation. The Status field is now
the single source of truth for what's done vs deferred, removing the
"forever Partial" doc drift the verifier flagged.
arcodange merged commit 4a3f1bb138 into main 2026-05-05 08:07:09 +02:00
arcodange deleted branch docs/homogenize-partial-adrs 2026-05-05 08:07:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
arcodange
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#39
Delete Branch "docs/homogenize-partial-adrs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?