arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

🐛 fix(bdd): exclude @v2 scenarios from default BDD test runs #27

Merged
arcodange merged 1 commits from fix/exclude-v2-from-default-bdd into main 2026-05-03 13:59:27 +02:00
Conversation 0 Commits 1 Files Changed 2 +4 -1
arcodange commented 2026-05-03 13:59:13 +02:00
Owner
Copy Link

Summary

The 4 v2 scenarios in greet.feature need FEATURE=greet + GODOG_TAGS=@v2 to work. Without that, they fail with 'v2 endpoint not available'. CI doesn't set those, so v2 scenarios are systematically failing in default runs.

Two fixes

  1. Tag 3 untagged v2 scenarios with @v2 @api (one already had it)
  2. Extend DEFAULT_TAGS in run-bdd-tests.sh to exclude @v2

Result

CI default runs pass cleanly. v2 still testable on demand:
FEATURE=greet GODOG_TAGS=@v2 go test ./features/greet/...

Companion to PR #26 (BDD_SCHEMA_ISOLATION). Both target CI green for daily PRs.

Diagnosed during the 2026-05-03 trainer day after observing the v2 failures in CI #608.

## Summary The 4 v2 scenarios in greet.feature need FEATURE=greet + GODOG_TAGS=@v2 to work. Without that, they fail with 'v2 endpoint not available'. CI doesn't set those, so v2 scenarios are systematically failing in default runs. ## Two fixes 1. Tag 3 untagged v2 scenarios with `@v2 @api` (one already had it) 2. Extend DEFAULT_TAGS in run-bdd-tests.sh to exclude `@v2` ## Result CI default runs pass cleanly. v2 still testable on demand: `FEATURE=greet GODOG_TAGS=@v2 go test ./features/greet/...` Companion to PR #26 (BDD_SCHEMA_ISOLATION). Both target CI green for daily PRs. Diagnosed during the 2026-05-03 trainer day after observing the v2 failures in CI #608.
arcodange added 1 commit 2026-05-03 13:59:14 +02:00
🐛 fix(bdd): exclude @v2 scenarios from default BDD test runs
All checks were successful
CI/CD Pipeline / Build Docker Cache (push) Successful in 25s
Details
CI/CD Pipeline / CI Pipeline (push) Successful in 7m37s
Details
CI/CD Pipeline / Trigger Docker Push (push) Has been skipped
Details
6b39d3c3c9 
The 4 v2 scenarios in greet.feature require special config
(FEATURE=greet GODOG_TAGS=@v2) to enable the v2 endpoint via
shouldEnableV2(). Without that config, all v2 scenarios fail
with "v2 endpoint not available".

Two fixes:
1. Tag the 3 untagged v2 scenarios with @v2 @api (one already
   had it, others were missing tags)
2. Extend DEFAULT_TAGS in run-bdd-tests.sh to exclude @v2

This makes the default BDD test run pass on CI without v2 setup.
v2 scenarios can still be run explicitly with:
  FEATURE=greet GODOG_TAGS=@v2 go test ./features/greet/...

Companion to PR #26 (BDD_SCHEMA_ISOLATION) - both target CI green.

🤖 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
arcodange merged commit 11fefe3bd9 into main 2026-05-03 13:59:27 +02:00
arcodange deleted branch fix/exclude-v2-from-default-bdd 2026-05-03 13:59:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
arcodange
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: arcodange/dance-lessons-coach#27
Delete Branch "fix/exclude-v2-from-default-bdd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?