arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

✨ feat(server): wire sampler hot-reload callback (ADR-0023 Phase 3, sub-phase 3.3) (#49)
Some checks failed
CI/CD Pipeline / Build Docker Cache (push) Successful in 14s
Details
CI/CD Pipeline / Trigger Docker Push (push) Has been cancelled
Details
CI/CD Pipeline / CI Pipeline (push) Has been cancelled
Details

Browse Source 
Co-authored-by: Gabriel Radureau <arcodange@gmail.com>
Co-committed-by: Gabriel Radureau <arcodange@gmail.com>
This commit was merged in pull request #49.
This commit is contained in:
Gabriel Radureau
2026-05-05 09:42:38 +02:00
committed by arcodange
parent f97b6874c9
commit 92a8027dd4
2 changed files with 25 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
pkg/server/server.go
View File

@@ -679,10 +679,11 @@ func (s *Server) Router() http.Handler {
func (s *Server) Run() error {
// Initialize OpenTelemetry if enabled
var err error
var telemetrySetup *telemetry.Setup
if s.withOTEL {
log.Trace().Msg("Initializing OpenTelemetry tracing")
telemetrySetup := &telemetry.Setup{
telemetrySetup = &telemetry.Setup{
ServiceName: s.config.GetServiceName(),
OTLPEndpoint: s.config.GetOTLPEndpoint(),
Insecure: s.config.GetTelemetryInsecure(),
@@ -694,6 +695,7 @@ func (s *Server) Run() error {
if s.tracerProvider, err = telemetrySetup.InitializeTracing(context.Background()); err != nil {
log.Error().Err(err).Msg("Failed to initialize OpenTelemetry, continuing without tracing")
s.withOTEL = false
telemetrySetup = nil
} else {
log.Trace().Msg("OpenTelemetry tracing initialized successfully")
}
@@ -714,7 +716,27 @@ func (s *Server) Run() error {
s.userService.StartJWTSecretCleanupLoop(rootCtx, s.config.GetJWTSecretCleanupInterval())
}
// Start config hot-reload watcher (ADR-0023 Phase 1: logging.level only).
// Wire the sampler hot-reload callback (ADR-0023 Phase 3, sub-phase 3.3).
// telemetrySetup is non-nil only when telemetry was successfully initialized
// at startup — hot-reloading telemetry-on is out of scope (see ADR-0023).
// The callback updates the SamplerType/Ratio on the captured Setup, then
// rebuilds the global tracer provider via ReconfigureTracerProvider.
if telemetrySetup != nil {
s.config.SetSamplerReconfigureCallback(func(ctx context.Context, samplerType string, samplerRatio float64) error {
telemetrySetup.SamplerType = samplerType
telemetrySetup.SamplerRatio = samplerRatio
newTP, rerr := telemetrySetup.ReconfigureTracerProvider(ctx, s.tracerProvider)
if rerr != nil {
return rerr
}
if newTP != nil {
s.tracerProvider = newTP
}
return nil
})
}
// Start config hot-reload watcher (ADR-0023 Phase 1+2+3).
// Stops automatically on rootCtx cancellation.
s.config.WatchAndApply(rootCtx)