Implement comprehensive graceful shutdown with JSON logging
- Added signal.NotifyContext for modern signal handling in cmd/server/main.go - Implemented BaseContext for proper context propagation to HTTP handlers - Added readiness drain delay before shutdown for graceful degradation - Fixed PID detection in start-server.sh to target actual server process - Added Logging.JSON configuration option with DLC_LOGGING_JSON environment variable - Created comprehensive test script that validates entire server lifecycle - Updated documentation with JSON logging configuration examples - All shutdown logs now appear correctly in JSON format - Server terminates gracefully on SIGTERM with proper log flushing The graceful shutdown implementation follows VictoriaMetrics best practices: 1. Catches termination signals (SIGTERM, SIGINT) 2. Stops accepting new requests but allows ongoing requests to complete 3. Waits for active requests to finish within configured timeout 4. Releases resources and performs cleanup 5. Logs all shutdown steps for observability Test script validates: - Server startup and API functionality - Graceful shutdown sequence - JSON log format validation - Complete log sequence verification - Proper signal handling and context propagation Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This commit is contained in:
@@ -42,6 +42,8 @@ server:
|
||||
port: 8080
|
||||
shutdown:
|
||||
timeout: 30s
|
||||
logging:
|
||||
json: false # Set to true for JSON format logging
|
||||
```
|
||||
|
||||
Then start the server:
|
||||
@@ -72,6 +74,7 @@ You can also configure via environment variables with `DLC_` prefix:
|
||||
export DLC_SERVER_HOST="0.0.0.0"
|
||||
export DLC_SERVER_PORT=8080
|
||||
export DLC_SHUTDOWN_TIMEOUT=30s
|
||||
export DLC_LOGGING_JSON=false # Set to true for JSON format logging
|
||||
|
||||
# Start the server
|
||||
go run ./cmd/server
|
||||
|
||||
Reference in New Issue
Block a user