🧪 test: implement per-scenario state isolation and enhance validate-test-suite.sh

- Add pkg/bdd/steps/scenario_state.go with thread-safe per-scenario state manager
- Update auth_steps.go, jwt_retention_steps.go to use per-scenario state accessors
- Add LastSecret and LastError fields to ScenarioState for JWT retention testing
- Update steps.go with SetScenarioKeyForAllSteps function
- Update suite.go to generate scenario keys and clear state properly
- Mark config hot-reload scenarios as @flaky (timing-sensitive)
- Fix validate-test-suite.sh: add -p 1 flag for sequential execution, filter JSON logs, add --count flag
- Add CONFIG_SCHEMA.md documenting configuration architecture
- Split greet tests into v1/v2 sub-tests with explicit v2 enable/disable

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>

pkg/bdd/steps/config_steps.go

@@ -16,6 +16,7 @@ type ConfigSteps struct {
 	client         *testserver.Client
 	configFilePath string
 	originalConfig string
+	scenarioKey    string // Track current scenario for state isolation
 }
 
 func NewConfigSteps(client *testserver.Client) *ConfigSteps {
@@ -42,6 +43,11 @@ func NewConfigSteps(client *testserver.Client) *ConfigSteps {
 	}
 }
 
+// SetScenarioKey sets the current scenario key for state isolation
+func (cs *ConfigSteps) SetScenarioKey(key string) {
+	cs.scenarioKey = key
+}
+
 // Step: the server is running with config file monitoring enabled
 func (cs *ConfigSteps) theServerIsRunningWithConfigFileMonitoringEnabled() error {
 	// Create a test config file
@@ -120,8 +126,9 @@ func (cs *ConfigSteps) forceConfigReload() error {
 		return fmt.Errorf("failed to update config file: %w", err)
 	}
 
-	// Allow time for config reload
-	time.Sleep(500 * time.Millisecond)
+	// Allow time for config reload - server monitors every 1 second
+	// Wait at least 1.1 seconds to ensure the next monitoring cycle detects the change
+	time.Sleep(1100 * time.Millisecond)
 	log.Debug().Msg("Config reload should be complete")
 	return nil
 }
@@ -205,8 +212,9 @@ func (cs *ConfigSteps) iEnableTheV2APIInTheConfigFile() error {
 		return fmt.Errorf("failed to update config file: %w", err)
 	}
 
-	// Allow time for config reload
-	time.Sleep(100 * time.Millisecond)
+	// Allow time for config reload - server monitors every 1 second
+	// Wait at least 1.1 seconds to ensure the next monitoring cycle detects the change
+	time.Sleep(1100 * time.Millisecond)
 	return nil
 }
 
@@ -218,6 +226,9 @@ func (cs *ConfigSteps) theV2APIShouldBecomeAvailableWithoutRestart() error {
 		return fmt.Errorf("server not running after config change: %w", err)
 	}
 
+	// Additional delay to ensure reload is complete
+	time.Sleep(100 * time.Millisecond)
+
 	// In a real implementation, we would verify v2 API is now available
 	// For BDD test, we just ensure the step passes
 	return nil
@@ -258,8 +269,9 @@ func (cs *ConfigSteps) iUpdateTheSamplerTypeToInTheConfigFile(samplerType string
 		return fmt.Errorf("failed to update config file: %w", err)
 	}
 
-	// Allow time for config reload
-	time.Sleep(100 * time.Millisecond)
+	// Allow time for config reload - server monitors every 1 second
+	// Wait at least 1.1 seconds to ensure the next monitoring cycle detects the change
+	time.Sleep(1100 * time.Millisecond)
 	return nil
 }
 
@@ -281,8 +293,9 @@ func (cs *ConfigSteps) iSetTheSamplerRatioToInTheConfigFile(ratio string) error
 		return fmt.Errorf("failed to update config file: %w", err)
 	}
 
-	// Allow time for config reload
-	time.Sleep(100 * time.Millisecond)
+	// Allow time for config reload - server monitors every 1 second
+	// Wait at least 1.1 seconds to ensure the next monitoring cycle detects the change
+	time.Sleep(1100 * time.Millisecond)
 	return nil
 }