arcodange/dance-lessons-coach
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

🐛 fix(bdd): exclude @v2 scenarios from default BDD test runs
All checks were successful
CI/CD Pipeline / Build Docker Cache (push) Successful in 25s
Details
CI/CD Pipeline / CI Pipeline (push) Successful in 7m37s
Details
CI/CD Pipeline / Trigger Docker Push (push) Has been skipped
Details

Browse Source 
The 4 v2 scenarios in greet.feature require special config
(FEATURE=greet GODOG_TAGS=@v2) to enable the v2 endpoint via
shouldEnableV2(). Without that config, all v2 scenarios fail
with "v2 endpoint not available".

Two fixes:
1. Tag the 3 untagged v2 scenarios with @v2 @api (one already
   had it, others were missing tags)
2. Extend DEFAULT_TAGS in run-bdd-tests.sh to exclude @v2

This makes the default BDD test run pass on CI without v2 setup.
v2 scenarios can still be run explicitly with:
  FEATURE=greet GODOG_TAGS=@v2 go test ./features/greet/...

Companion to PR #26 (BDD_SCHEMA_ISOLATION) - both target CI green.

🤖 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Gabriel Radureau
2026-05-03 13:59:11 +02:00
parent 9b6c384eb2
commit 6b39d3c3c9
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
features/greet/greet.feature
View File

@@ -21,16 +21,19 @@ Feature: Greet Service
When I send a POST request to v2 greet with name "John" When I send a POST request to v2 greet with name "John"
Then the response should be "{\"message\":\"Hello my friend John!\"}" Then the response should be "{\"message\":\"Hello my friend John!\"}"
@v2 @api
Scenario: v2 default greeting with empty name Scenario: v2 default greeting with empty name
Given the server is running with v2 enabled Given the server is running with v2 enabled
When I send a POST request to v2 greet with name "" When I send a POST request to v2 greet with name ""
Then the response should be "{\"message\":\"Hello my friend!\"}" Then the response should be "{\"message\":\"Hello my friend!\"}"
@v2 @api
Scenario: v2 greeting with missing name field Scenario: v2 greeting with missing name field
Given the server is running with v2 enabled Given the server is running with v2 enabled
When I send a POST request to v2 greet with invalid JSON "{}" When I send a POST request to v2 greet with invalid JSON "{}"
Then the response should be "{\"message\":\"Hello my friend!\"}" Then the response should be "{\"message\":\"Hello my friend!\"}"
@v2 @api
Scenario: v2 greeting with name that is too long Scenario: v2 greeting with name that is too long
Given the server is running with v2 enabled Given the server is running with v2 enabled
When I send a POST request to v2 greet with name "ThisNameIsWayTooLongAndShouldFailValidationBecauseItExceedsTheMaximumAllowedLengthOf100Characters!!!!" When I send a POST request to v2 greet with name "ThisNameIsWayTooLongAndShouldFailValidationBecauseItExceedsTheMaximumAllowedLengthOf100Characters!!!!"

2
scripts/run-bdd-tests.sh
View File

@@ -133,7 +133,7 @@ run_tests_with_tags() {
set +e set +e
# Default tag filter: exclude flaky, todo, and skip scenarios # Default tag filter: exclude flaky, todo, and skip scenarios
DEFAULT_TAGS="~@flaky && ~@todo && ~@skip" DEFAULT_TAGS="~@flaky && ~@todo && ~@skip && ~@v2"
if [ -n "$tags" ]; then if [ -n "$tags" ]; then
# Use godog directly for tag filtering with exclusion # Use godog directly for tag filtering with exclusion