arcodange-org/url-shortener
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added a basic input validation for shortUrl

Browse Source
This commit is contained in:
Przemek Dragańczuk
2020-02-16 16:05:09 +01:00
parent 8cd399d2e9
commit 1322569cf6
3 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/main/java/tk/draganczuk/url/Routes.java
View File

@@ -1,5 +1,6 @@
package tk.draganczuk.url;
import org.eclipse.jetty.http.HttpStatus;
import spark.Request;
import spark.Response;
@@ -29,15 +30,21 @@ public class Routes {
shortUrl = Utils.randomString();
}
return urlFile.addUrl(longUrl, shortUrl);
if (Utils.validate(shortUrl)) {
return urlFile.addUrl(longUrl, shortUrl);
} else {
res.status(HttpStatus.BAD_REQUEST_400);
return "shortUrl not valid ([a-z0-9]+)";
}
}
public static String goToLongUrl(Request req, Response res){
public static String goToLongUrl(Request req, Response res) {
String shortUrl = req.params("shortUrl");
var longUrlOpt = urlFile
.findForShortUrl(shortUrl);
.findForShortUrl(shortUrl);
if(longUrlOpt.isEmpty()){
if (longUrlOpt.isEmpty()) {
res.status(404);
return "";
}