feat(write-skill): idempotency keys — manifest replay is a no-op (erp#44)

Learning #4 of the 2026-07-11 rehearsal: manifest B failed mid-run and could
not be re-applied — op 1 (the DARNIS invoice) had already run and a replay
would have duplicated it. Every write op now dedupes BEFORE any POST:

- thirdparty-create.sh: by exact name (promote '#thirdparty:name=' semantics);
  ambiguous (2+) aborts; an existing fiche missing the requested role aborts
  (refuse-never-repair). Emits {"id", "deduped"} instead of a bare id.
- invoice-create.sh: supplier kind by (socid, ref_supplier) — same key with a
  different total aborts as a conflict; customer kind (or supplier without
  ref_supplier) by (socid, date, total_ttc ±0.02, line fingerprint) with descs
  HTML-unescaped. Credit notes are never candidates. A deduped DRAFT with
  validate:true is validated on replay, so an interrupted run converges.
- payment-record.sh: by (invoice, amount, normalized transaction_id), composing
  with the erp#37 varchar(50) normalization on BOTH sides so historical
  long-form nums still match; same tx + different amount aborts; without a tx
  id there is no dedupe key (warned). Dedupe answers id:null (the payments list
  exposes no paiement rowid) + the existing bank line.
- All three refuse to POST blind when the dedupe lookup fails with anything but
  the documented empty-list 404 (the voir_tous trap would otherwise mint dupes).
- promote-apply.sh: marks each op created / deduped=true inline and totals them
  in the summary — an all-deduped second run is visible proof of a no-op.
- promote-plan.sh: advertises each op's dedupe key (and flags tx=MISSING as
  'a replay WILL double-pay').

Proof:
- tests/run-tests.sh: 5 new offline cases (11 total) — dedupe hits POST
  nothing, conflicts/ambiguity abort pre-POST, long-form history dedupes,
  draft convergence validates; stub extended to serve the new lookups with the
  live-observed empty behaviors ([] for invoices/payments, 404 for tiers).
- tests/replay-idempotency.sh (new, live): double-applies a self-contained
  manifest on the sandbox — run 1 '3 created' (rows 1/1/1), run 2 '3 deduped'
  with row counts unchanged and the stored num in erp#37 short form.
- The historic manifest-B now replays on the sandbox as 5/5 deduped, zero new
  rows — the exact replay Learning #4 declared impossible.

SKILL.md updated in the same change (per-op dedupe keys, replay-safety section,
gotchas); the 2026-07-11 runbook's Learning #4 carries a dated resolution
addendum.

Closes erp#44.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VRShc4QhLLU73FLHx9vskh

.claude/skills/dolibarr-sandbox-write/scripts/promote-plan.sh

@@ -17,11 +17,17 @@ for i, op in enumerate(ops, 1):
     t = op["op"]; inp = op.get("input", {}); ref = op.get("ref")
     print("  %d. %s%s" % (i, t, ("  => @%s" % ref) if ref else ""))
     if t == "thirdparty":
-        print("       name=%r role=%s%s" % (inp.get("name"), inp.get("role", "client"),
+        print("       name=%r role=%s%s (idempotent: dedupe by exact name; ambiguous aborts)"
+              % (inp.get("name"), inp.get("role", "client"),
               (" tva=%s" % inp["tva_intra"]) if inp.get("tva_intra") else ""))
     elif t == "invoice":
-        print("       socid=%s kind=%s%s validate=%s" % (inp.get("socid"), inp.get("kind", "customer"),
-              (" ref_supplier=%s" % inp["ref_supplier"]) if inp.get("ref_supplier") else "", bool(inp.get("validate"))))
+        supplier = str(inp.get("kind", "customer")).lower() in ("supplier", "fournisseur")
+        dk = ("socid+ref_supplier" if supplier and inp.get("ref_supplier")
+              else "socid+date+total+lines")
+        print("       socid=%s kind=%s%s validate=%s (idempotent: dedupe by %s)"
+              % (inp.get("socid"), inp.get("kind", "customer"),
+              (" ref_supplier=%s" % inp["ref_supplier"]) if inp.get("ref_supplier") else "",
+              bool(inp.get("validate")), dk))
         for ln in inp.get("lines", []):
             print("         - %r qty=%s pu_ht=%s tva=%s%% [%s]" % (ln.get("desc", ""), ln.get("qty", 1),
                   ln.get("price_ht", ln.get("subprice")), ln.get("tva", ln.get("tva_tx", 20)), ln.get("type", "service")))
@@ -34,7 +40,8 @@ for i, op in enumerate(ops, 1):
         txid = inp.get("transaction_id") or inp.get("num")
         print("       invoice=%s mode=%s account=%s %s%s" % (inp.get("invoice_id"), inp.get("mode", "VIR"),
               inp.get("account_id"), ("amount=%s" % inp["amount"]) if inp.get("amount") else "(full)",
-              (" tx=%s" % txid) if txid else " tx=MISSING"))
+              (" tx=%s (idempotent: dedupe by invoice+amount+tx)" % txid) if txid
+              else " tx=MISSING (no dedupe key — a replay WILL double-pay)"))
     elif t == "thirdparty_update":
         flds = inp.get("fields") or {}
         print("       socid=%s update %d dossier field(s): %s" % (inp.get("socid"), len(flds),