feat(write-skill): idempotency keys — manifest replay is a no-op (erp#44)

Learning #4 of the 2026-07-11 rehearsal: manifest B failed mid-run and could
not be re-applied — op 1 (the DARNIS invoice) had already run and a replay
would have duplicated it. Every write op now dedupes BEFORE any POST:

- thirdparty-create.sh: by exact name (promote '#thirdparty:name=' semantics);
  ambiguous (2+) aborts; an existing fiche missing the requested role aborts
  (refuse-never-repair). Emits {"id", "deduped"} instead of a bare id.
- invoice-create.sh: supplier kind by (socid, ref_supplier) — same key with a
  different total aborts as a conflict; customer kind (or supplier without
  ref_supplier) by (socid, date, total_ttc ±0.02, line fingerprint) with descs
  HTML-unescaped. Credit notes are never candidates. A deduped DRAFT with
  validate:true is validated on replay, so an interrupted run converges.
- payment-record.sh: by (invoice, amount, normalized transaction_id), composing
  with the erp#37 varchar(50) normalization on BOTH sides so historical
  long-form nums still match; same tx + different amount aborts; without a tx
  id there is no dedupe key (warned). Dedupe answers id:null (the payments list
  exposes no paiement rowid) + the existing bank line.
- All three refuse to POST blind when the dedupe lookup fails with anything but
  the documented empty-list 404 (the voir_tous trap would otherwise mint dupes).
- promote-apply.sh: marks each op created / deduped=true inline and totals them
  in the summary — an all-deduped second run is visible proof of a no-op.
- promote-plan.sh: advertises each op's dedupe key (and flags tx=MISSING as
  'a replay WILL double-pay').

Proof:
- tests/run-tests.sh: 5 new offline cases (11 total) — dedupe hits POST
  nothing, conflicts/ambiguity abort pre-POST, long-form history dedupes,
  draft convergence validates; stub extended to serve the new lookups with the
  live-observed empty behaviors ([] for invoices/payments, 404 for tiers).
- tests/replay-idempotency.sh (new, live): double-applies a self-contained
  manifest on the sandbox — run 1 '3 created' (rows 1/1/1), run 2 '3 deduped'
  with row counts unchanged and the stored num in erp#37 short form.
- The historic manifest-B now replays on the sandbox as 5/5 deduped, zero new
  rows — the exact replay Learning #4 declared impossible.

SKILL.md updated in the same change (per-op dedupe keys, replay-safety section,
gotchas); the 2026-07-11 runbook's Learning #4 carries a dated resolution
addendum.

Closes erp#44.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VRShc4QhLLU73FLHx9vskh

.claude/skills/dolibarr-sandbox-write/scripts/promote-apply.sh

@@ -40,6 +40,7 @@ OP_SCRIPT = {"thirdparty": "thirdparty-create.sh", "invoice": "invoice-create.sh
              "creditnote": "creditnote-create.sh", "payment": "payment-record.sh",
              "thirdparty_update": "thirdparty-update.sh", "contact": "contact-create.sh"}
 refmap = {}
+n_created = n_deduped = 0
 
 import urllib.parse
 DOL_WRITE = os.environ.get("DOL_WRITE")  # GET wrapper for the chosen target
@@ -117,16 +118,28 @@ for i, op in enumerate(ops, 1):
     ref = op.get("ref")
     if ref and rid is not None:
         refmap[ref] = int(rid) if str(rid).isdigit() else rid
-    # Surface the idempotency evidence inline: contact dedupes and
-    # thirdparty-update read-back diffs are the proof a re-apply is a no-op.
+    # Surface the idempotency evidence inline: every op script reports
+    # deduped=true/false (erp#44), and thirdparty-update reports its read-back
+    # diff — together the proof a re-apply is a no-op.
     extra = ""
     if isinstance(parsed, dict):
         if parsed.get("deduped"):
+            n_deduped += 1
             extra += "  deduped=true (already on target — no write)"
+        elif "deduped" in parsed:
+            n_created += 1
+            extra += "  created"
         ch = parsed.get("changed")
         if isinstance(ch, dict):
             extra += "  changed=%d%s" % (len(ch),
                      (" [%s]" % ", ".join(sorted(ch))) if ch else " (no-op)")
-    print("  [%d/%d] %-17s %-8s -> id=%s%s" % (i, len(ops), t, ("@" + ref) if ref else "", rid, extra))
-print("OK — promote complete. ref -> id: %s" % json.dumps(refmap))
+    print("  [%d/%d] %-17s %-8s -> id=%s%s" % (i, len(ops), t, ("@" + ref) if ref else "",
+                                               rid if rid is not None else "-", extra))
+counts = []
+if n_created:
+    counts.append("%d created" % n_created)
+if n_deduped:
+    counts.append("%d deduped" % n_deduped)
+print("OK — promote complete%s. ref -> id: %s"
+      % ((" (%s)" % ", ".join(counts)) if counts else "", json.dumps(refmap)))
 PY