feat(promote): resolve pre-existing entities by business key (#entity:field=value)

Closes the last promote gap: a manifest can now reference records it does NOT
create. A value like "#thirdparty:name=KissMetrics" (or :code=CL0007) is looked
up on the TARGET at apply time and resolved to that target's id — so the same
manifest is portable (sandbox id on --target sandbox, prod id on --target prod).

promote-apply.sh: resolve() gains a "#" branch + a lookup() helper that queries
the target via the GET wrapper with sqlfilters. Supports thirdparty
(name/code/supplier_code) and invoice/supplierinvoice (ref/ref_supplier). A
lookup matching nothing OR more than one record ABORTS the run — it never
guesses, so it cannot write to the wrong entity.

Proven live: "#thirdparty:name=ACME Conseil" resolved to the existing client and
invoiced it; a not-found code and an ambiguous (2-match) name both aborted with
exit 1. Combined with @refs, arbitrary self-contained-or-referential change-sets
now replay cleanly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-29 23:57:49 +02:00
parent 7949ab34f8
commit 04985fe15c
2 changed files with 57 additions and 4 deletions

View File

@@ -34,12 +34,55 @@ ops = json.load(open(manifest_path))
OP_SCRIPT = {"thirdparty": "thirdparty-create.sh", "invoice": "invoice-create.sh",
"creditnote": "creditnote-create.sh", "payment": "payment-record.sh"}
refmap = {}
import urllib.parse
DOL_WRITE = os.environ.get("DOL_WRITE") # GET wrapper for the chosen target
# Business-key lookup of a PRE-EXISTING entity on the target, so a manifest can
# reference records it does not create (e.g. an invoice for an existing client).
# Resolves against the *target*, so #thirdparty:name=X becomes the sandbox id on
# --target sandbox and the prod id on --target prod (portability for real changes).
ENTITY_LOOKUP = {
"thirdparty": ("/thirdparties", {"name": "t.nom", "code": "t.code_client",
"supplier_code": "t.code_fournisseur"}),
"invoice": ("/invoices", {"ref": "t.ref"}),
"supplierinvoice": ("/supplierinvoices", {"ref": "t.ref", "ref_supplier": "t.ref_supplier"}),
}
def lookup(spec):
try:
ent, rest = spec.split(":", 1); field, value = rest.split("=", 1)
except ValueError:
sys.exit("promote-apply: bad lookup '#%s' (use #entity:field=value)" % spec)
if ent not in ENTITY_LOOKUP:
sys.exit("promote-apply: unknown lookup entity '%s'" % ent)
endpoint, cols = ENTITY_LOOKUP[ent]
if field not in cols:
sys.exit("promote-apply: cannot look %s up by '%s' (try %s)" % (ent, field, "/".join(cols)))
flt = "(%s:=:'%s')" % (cols[field], value.replace("'", "''"))
path = "%s?limit=2&sqlfilters=%s" % (endpoint, urllib.parse.quote(flt))
r = subprocess.run([DOL_WRITE, "GET", path], capture_output=True, text=True, env=os.environ)
if r.returncode != 0:
sys.stderr.write(r.stdout + r.stderr + "\n")
sys.exit("promote-apply: lookup '#%s' query failed" % spec)
try:
rows = json.loads(r.stdout)
except Exception:
rows = []
rows = rows if isinstance(rows, list) else []
if len(rows) == 0:
sys.exit("promote-apply: lookup '#%s' matched nothing on the target" % spec)
if len(rows) > 1:
sys.exit("promote-apply: lookup '#%s' is ambiguous (%d matches) — use a unique key" % (spec, len(rows)))
return int(rows[0]["id"])
def resolve(v):
if isinstance(v, str) and v.startswith("@"):
k = v[1:]
if k not in refmap:
sys.exit("promote-apply: unresolved ref @%s (is it created earlier in the manifest?)" % k)
return refmap[k]
if isinstance(v, str) and v.startswith("#"):
return lookup(v[1:])
if isinstance(v, dict):
return {kk: resolve(vv) for kk, vv in v.items()}
if isinstance(v, list):